-
Notifications
You must be signed in to change notification settings - Fork 500
update otl and rand family deps #6038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 0 | ||
| }; | ||
|
|
||
| global::shutdown_tracer_provider(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to call .shutdown on the processor in order to flush and send the in-flight spans. You will have to refactor setup_logging_and_tracing a little bit to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returned the trace_provider from setup_logging_and_tracing, so it can be shutdown from main.rs.
| let parent_cx = | ||
| global::get_text_map_propagator(|prop| prop.extract(&MetadataMap(request_metadata))); | ||
| Span::current().set_parent(parent_cx); | ||
| let _ = Span::current().set_parent(parent_cx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When can this fail now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when I run cargo check --all-targets && cargo test in local, it is just warning:
warning: unused `Result` that must be used
--> quickwit-proto/src/lib.rs:199:5
|
199 | Span::current().set_parent(parent_cx);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: this `Result` may be an `Err` variant, which should be handled
= note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default
help: use `let _ = ...` to ignore the resulting value
|
199 | let _ = Span::current().set_parent(parent_cx);
| +++++++
But during CI phase, it shows as an error.
Description
cargo upgrade --incompatible
-p opentelemetry
-p opentelemetry_sdk
-p opentelemetry-otlp
-p tracing-opentelemetry
&& cargo check --all-targets
cargo upgrade --incompatible
-p rand
-p rand_distr
&& cargo check --all-targets && cargo test
How was this PR tested?
cargo check --all-targets && cargo test
make test-all