Add quotes to numeric answers - #1
Closed
dslavicek wants to merge 1 commit into
Closed
Conversation
I was unable to run the quiz when numbers were not quoted, because they were interpreted as numbers and violated expected format somewhere.
ZelenyMartin
requested changes
Feb 5, 2026
ZelenyMartin
left a comment
ZelenyMartin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the contribution with the fix! Unfortunately I'd go different way and allow users to use also non-string types in the answer field in YAML. Even that it semantically doesn't make sense to allow ints, floats and bools, we shouldn't limit it for the simplicity of creating a quiz in YAML.
I suggest that the Pydantic model should allow str | int | float | bool for this field, but we should immediately convert it to str.
Contributor
|
Closing in favor of the proper fix in quiz-common that handles type conversion at the model level |
Contributor
|
Closing in favor of the proper fix in quiz-common that handles type conversion at the model level |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to run the quiz when numbers were not quoted, because they were interpreted as numbers and violated expected format somewhere.