fix: Split Question model - #11
Closed
ZelenyMartin wants to merge 1 commit into
Closed
Conversation
We can't use `Question` model with the `correct` attribute to send to the admin/client. This commit splits it into parent and child classes. Child `Option` has everything what parent `OptionAnswer` has. I'm sending PRs to common and admin but you don't need to accept it.
ZelenyMartin
requested review from
JanaDrazkova,
dslavicek,
ninabel and
papricie
as code owners
April 25, 2026 21:41
|
@ZelenyMartin Should this be closed as "won't do"? |
Contributor
Author
|
We will continue this way: quiz-cli/quiz-common#7 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use
Questionmodel with thecorrectattribute to send to the admin/client. This commit splits it into parent and child classes. ChildOptionhas everything what parentOptionAnswerhas.I'm sending PRs to common and admin but you don't need to accept it.