Duplicate names - #26
Open
JanaDrazkova wants to merge 4 commits into
Open
Conversation
JanaDrazkova
requested review from
ZelenyMartin,
dslavicek,
ninabel and
papricie
as code owners
June 9, 2026 18:38
Contributor
|
Is it possible to ask player about a new name without closing connection? |
Contributor
Author
|
At this moment is |
Collaborator
|
I suggest to provide just method |
Collaborator
|
Can you support this PR with a test? (PR to the quiz-tests, branch with the same name). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A player cannot connect to the server if the client name is already in use.