add vctrs methods to make rectangling nicer#226
Merged
lionel- merged 7 commits intor-lib:mainfrom Sep 19, 2025
Merged
Conversation
lionel-
reviewed
Sep 19, 2025
| }) | ||
|
|
||
|
|
||
| test_that("gh_response objects can be combined via vctrs #161", { |
| # Add vctrs methods that strip attributes from gh_response when combining, | ||
| # enabling rectangling via unnesting etc | ||
| # See <https://github.com/r-lib/gh/issues/161> for more details | ||
| #' @exportS3Method vctrs::vec_ptype2 |
Member
There was a problem hiding this comment.
Here and below: exportS3Method uses delayed method registration. I think we need a regular export here: @export.
Contributor
Author
There was a problem hiding this comment.
@lionel- I'm getting an error here with a normal @export because we don't import the generic vec_ptype2 (or maybe because we don't export it?). I think delayed might be better (and make vctrs a suggests)?
https://github.com/r-lib/gh/actions/runs/17863952750/job/50801557570?pr=226#step:6:181
lionel-
reviewed
Sep 19, 2025
Member
lionel-
left a comment
There was a problem hiding this comment.
Could you please revert the air formatting commit? PRs should be focused on one thing so they are easier to evaluate by the reviewer. An air format commit should be its own PR.
15ca523 to
3a6d520
Compare
4595042 to
323affe
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161, resurrects #201 (got closed accidentally) as part of tidy dev day:
Adds vctrs methods provided by @DavisVaughan to help
gh_responseplay more nicely with vctrs rectangling toolkit.Test instructions: