Use rdtools#337
Open
hadley wants to merge 9 commits into
Open
Conversation
lionel-
approved these changes
Jul 7, 2026
|
|
||
| * `dev_example()` now expands the package's custom Rd macros when running examples, matching the behaviour of `dev_help()`. | ||
| * `dev_help()` and friends now use the rdtools package to build and look up the topic index, which is considerably faster. `dev_topic_index()` now returns a named character vector mapping alias to Rd file name (without extension), and an alias documented in multiple Rd files now triggers a warning. | ||
| * `dev_help()` no longer carries a workaround for versions of RStudio that predate `previewRd()`; outside of RStudio, HTML help now opens directly in your browser. |
Member
There was a problem hiding this comment.
Maybe mention the year? I saw in removed code that the minimum version is from 2022?
| rstudio_preview <- type == "html" && | ||
| is_installed("rstudioapi") && | ||
| rstudioapi::isAvailable() && | ||
| rstudioapi::hasFun("previewRd") |
Member
There was a problem hiding this comment.
Maybe keep the "2022.12.0.256" check and ref to rstudio#12111?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.