Fix Objective-C compatebility#48
Fix Objective-C compatebility#48ikorich wants to merge 1 commit intora1028:masterfrom ikorich:master
Conversation
|
@ikorich |
|
Hi @ra1028 I don't want remove it, because thats not for obj-c fix, Also I can fix some issues, just mark it for me |
|
But, it's not require in |
| } | ||
|
|
||
| public protocol RAReorderableLayoutDataSource: UICollectionViewDataSource { | ||
| func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell |
There was a problem hiding this comment.
It appears to be a re-definition of the same function defined in UICollectionViewDataSource
|
|
||
| public protocol RAReorderableLayoutDataSource: UICollectionViewDataSource { | ||
| func collectionView(_ collectionView: UICollectionView, cellForItemAt indexPath: IndexPath) -> UICollectionViewCell | ||
| func collectionView(_ collectionView: UICollectionView, numberOfItemsInSection section: Int) -> Int |
|
@ra1028 also any chance of getting this PR merged. It's needed for ObjC compatibility. |
|
After further investigation, I'm not convinced that these protocol methods should be marked as From my testing in an ObjC project using this pod as a dependency, with the Swift 3.2 compiler, if the methods are marked |
4 participants
RAReorderableLayoutDataSource and RAReorderableLayoutDelegate are hidden for Objective-C.
need add
to protocols