This repository was archived by the owner on May 26, 2019. It is now read-only.
Fixed incorrect removing IndexPath in example#57
Open
DzmitrySmaliakou wants to merge 1 commit intora1028:masterfrom
Open
Fixed incorrect removing IndexPath in example#57DzmitrySmaliakou wants to merge 1 commit intora1028:masterfrom
DzmitrySmaliakou wants to merge 1 commit intora1028:masterfrom
Conversation
In HorizontalViewController was removed always toIndexPath. But correct way is remove book from "at" IndexPath and insert "to" IndexPath.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In HorizontalViewController in moving data logic always uses toIndexPath. But correct way is remove book from "at" IndexPath and insert "to" IndexPath.