Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability#69

Draft
raccioly wants to merge 1 commit intomainfrom
sentinel-fix-command-injection-3960551479070147211
Draft

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability#69
raccioly wants to merge 1 commit intomainfrom
sentinel-fix-command-injection-3960551479070147211

Conversation

@raccioly
Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Command Injection. The ensureSpecKit function in cli/ensure-skills.mjs was using execSync to run specify init. The command constructed included user-controlled data via the detectedAgent variable (loaded from .specify/init-options.json or other agent config files). A malicious repository could supply a payload (e.g., ; rm -rf /) that would execute arbitrary shell commands when the user runs any docguard command.
🎯 Impact: Remote Code Execution (RCE). An attacker could compromise a developer's machine simply by having them run docguard in a project with a malicious configuration file.
πŸ”§ Fix: Replaced the vulnerable execSync call with execFileSync. The command arguments are now constructed and passed securely as an array, preventing any shell interpolation. A safe fallback using a try-catch for specify.cmd was added to ensure Windows compatibility.
βœ… Verification:

  • Validated via a custom Proof-of-Concept payload script that confirmed the exploit is now neutralized.
  • Ran the full pnpm test suite to ensure no functional regressions (61 passing tests, 0 failures).

PR created automatically by Jules for task 3960551479070147211 started by @raccioly

Replaced execSync with execFileSync to prevent command injection when
initializing specify-cli. Arguments are now passed securely as an array,
and shell metacharacters in the AI agent configuration can no longer
execute arbitrary code. Added a platform-aware fallback for Windows.

Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant