π‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability#69
π‘οΈ Sentinel: [CRITICAL] Fix command injection vulnerability#69
Conversation
Replaced execSync with execFileSync to prevent command injection when initializing specify-cli. Arguments are now passed securely as an array, and shell metacharacters in the AI agent configuration can no longer execute arbitrary code. Added a platform-aware fallback for Windows. Co-authored-by: raccioly <63126795+raccioly@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command Injection. The
ensureSpecKitfunction incli/ensure-skills.mjswas usingexecSyncto runspecify init. The command constructed included user-controlled data via thedetectedAgentvariable (loaded from.specify/init-options.jsonor other agent config files). A malicious repository could supply a payload (e.g.,; rm -rf /) that would execute arbitrary shell commands when the user runs anydocguardcommand.π― Impact: Remote Code Execution (RCE). An attacker could compromise a developer's machine simply by having them run
docguardin a project with a malicious configuration file.π§ Fix: Replaced the vulnerable
execSynccall withexecFileSync. The command arguments are now constructed and passed securely as an array, preventing any shell interpolation. A safe fallback using a try-catch forspecify.cmdwas added to ensure Windows compatibility.β Verification:
pnpm testsuite to ensure no functional regressions (61 passing tests, 0 failures).PR created automatically by Jules for task 3960551479070147211 started by @raccioly