Triage self-scan findings: HEALTHCHECK and transport suppression#27
Triage self-scan findings: HEALTHCHECK and transport suppression#27google-labs-jules[bot] wants to merge 1 commit into
Conversation
Fixes the `docker-no-healthcheck` finding by adding `HEALTHCHECK NONE` to Dockerfile, as the CLI image does not require a running daemon health check. Suppresses the `weak-csp` finding from `transport_security` via `.websec-ignore` because this repo is a CLI tool, not a web application serving HTML.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What:
Triage the findings from
websec run .on this repository. Specifically:docker-no-healthcheck(Dockerfile): AddedHEALTHCHECK NONE. This image executes a CLI tool and terminates, making a daemon health check inapplicable.weak-csp(transport_security extractor): Suppressedcategory:transportin.websec-ignore. The codebase is a Python CLI and does not serve a web frontend to a browser, so transport headers (CSP/HSTS) are not relevant here.Why:
To dogfood our own tool cleanly and remove noise from the baseline findings ledger.
Risk:
Low. Changes are restricted to the local Dockerfile (explicitly disabling a health check is correct for CLI containers) and
.websec-ignore(suppressing transport warnings for a non-transport CLI). All tests continue to pass.PR created automatically by Jules for task 243750414491847075 started by @raccioly