fix(extractors): detect ssrf in needle methods#28
fix(extractors): detect ssrf in needle methods#28google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
What
Updated the
ssrfandssrf-outbound-httpregular expressions insrc/websec_validator/extractors/surface.pyto match methods called on theneedlemodule, such asneedle.get(url).Why
During a check against the
websec-corpus/NodeGoatapplication, an SSRF vulnerability located inapp/routes/research.jswas completely missed by the existing regex. The vulnerability was triggered by a call toneedle.get(url). The existing regex correctly identifiedneedle(url)but didn't allow optional methods likeaxiosdid.Risk
The risk is low. This broadens the match to methods on
needleexactly identically to howaxiosis treated (needle(?:\.\w+)?). We added a regression test for this specific vulnerability intests/test_pentest_regressions.pyand confirmedwebsec proofcorrectly parses NodeGoat and reports thessrf-outbound-httpmatch. All tests pass anddocguarddocumentation changes (incrementing the test count) are in sync.PR created automatically by Jules for task 14721728081808018612 started by @raccioly