Skip to content

fix(extractors): detect ssrf in needle methods#28

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
jules-14721728081808018612-9ad9d5b0
Open

fix(extractors): detect ssrf in needle methods#28
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
jules-14721728081808018612-9ad9d5b0

Conversation

@google-labs-jules

Copy link
Copy Markdown

What

Updated the ssrf and ssrf-outbound-http regular expressions in src/websec_validator/extractors/surface.py to match methods called on the needle module, such as needle.get(url).

Why

During a check against the websec-corpus/NodeGoat application, an SSRF vulnerability located in app/routes/research.js was completely missed by the existing regex. The vulnerability was triggered by a call to needle.get(url). The existing regex correctly identified needle(url) but didn't allow optional methods like axios did.

Risk

The risk is low. This broadens the match to methods on needle exactly identically to how axios is treated (needle(?:\.\w+)?). We added a regression test for this specific vulnerability in tests/test_pentest_regressions.py and confirmed websec proof correctly parses NodeGoat and reports the ssrf-outbound-http match. All tests pass and docguard documentation changes (incrementing the test count) are in sync.


PR created automatically by Jules for task 14721728081808018612 started by @raccioly

@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants