Fix false positives in UploadSecurityExtractor#29
Fix false positives in UploadSecurityExtractor#29google-labs-jules[bot] wants to merge 1 commit into
Conversation
…sitives\n\n- Fix KEY_FROM_NAME flagging benign originalname template strings.\n- Fix TRUST_CLIENT_MIME flagging safe usages like logging.\n- Fix ACCEPT_SVG flagging strict rejection cases.\n- Add permanent regression tests in `test_pentest_regressions.py`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Fixes multiple false positives in the
UploadSecurityExtractor. The regexes forKEY_FROM_NAME,TRUST_CLIENT_MIME, andACCEPT_SVGwere too broad, flagging benign usages like loggingreq.file.mimetypeor rejectingimage/svg+xml.Changes:
KEY_FROM_NAMEto ensure it only matches when assigned directly to a key/path variable (e.g.Key: req.file.originalname).TRUST_CLIENT_MIMEto negative lookbehind common logger functions (console.log,logger.info, etc.).test_upload_security_benign_fpscontaining benign samples to ensure FPs do not regress.PR created automatically by Jules for task 15582470766821012324 started by @raccioly