Skip to content

Fix false positives in UploadSecurityExtractor#29

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-upload-security-fps-15582470766821012324
Open

Fix false positives in UploadSecurityExtractor#29
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-upload-security-fps-15582470766821012324

Conversation

@google-labs-jules

Copy link
Copy Markdown

Fixes multiple false positives in the UploadSecurityExtractor. The regexes for KEY_FROM_NAME, TRUST_CLIENT_MIME, and ACCEPT_SVG were too broad, flagging benign usages like logging req.file.mimetype or rejecting image/svg+xml.

Changes:

  • Bounded KEY_FROM_NAME to ensure it only matches when assigned directly to a key/path variable (e.g. Key: req.file.originalname).
  • Updated TRUST_CLIENT_MIME to negative lookbehind common logger functions (console.log, logger.info, etc.).
  • Addressed SVG flagging using stricter bounded matches that exclude cases when a rejection logic acts on the condition.
  • Added regression test test_upload_security_benign_fps containing benign samples to ensure FPs do not regress.
  • Verified test suite passes fully, zero true-positive regressions. CHANGELOG updated and docguard remains fully compliant.

PR created automatically by Jules for task 15582470766821012324 started by @raccioly

…sitives\n\n- Fix KEY_FROM_NAME flagging benign originalname template strings.\n- Fix TRUST_CLIENT_MIME flagging safe usages like logging.\n- Fix ACCEPT_SVG flagging strict rejection cases.\n- Add permanent regression tests in `test_pentest_regressions.py`.
@google-labs-jules

Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants