Skip to content

Fix issue where ctrlf--finalize doesn't push starting point mark when auto-recenter enabled #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raxod502 merged 2 commits into from
Dec 12, 2025
Merged

Fix issue where ctrlf--finalize doesn't push starting point mark when auto-recenter enabled #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f544bea
push-mark even when ctrlf-auto-recenter is t
NicholasBHubbard Dec 10, 2025
c510edf
Added changelog entry for PR #133
NicholasBHubbard Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog].

## [Unreleased]
### Bugs fixed
* Point at start of search wasn't being added to the mark ring when
`ctrlf-auto-recenter` was enabled ([#133]).

## 1.6 (released 2022-11-11)
### Enhancements
* Improved evil-mode's search history integration so it will now use
Expand Down
6 changes: 3 additions & 3 deletions ctrlf.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,9 +981,9 @@ I have literally no idea why this is needed.")
And self-destruct this hook."
(remove-hook 'post-command-hook #'ctrlf--finalize)
(unless (= (point) ctrlf--starting-point)
(if ctrlf-auto-recenter
(set-window-start (get-buffer-window) ctrlf--final-window-start)
(push-mark ctrlf--starting-point))))
(when ctrlf-auto-recenter
(set-window-start (get-buffer-window) ctrlf--final-window-start))
(push-mark ctrlf--starting-point)))

(defun ctrlf--minibuffer-exit-hook ()
"Clean up CTRLF from minibuffer and self-destruct this hook."
Expand Down