Fixed Search issue in Primitives doc search - Issue #854#875
Fixed Search issue in Primitives doc search - Issue #854#875Praneshxo wants to merge 6 commits intoradix-ui:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you! Can you please run Prettier on all changed files to ensure formatting is consistent before I merge? |
algolia/config.development.json
Outdated
| { | ||
| "index_name": "development_docs", | ||
| "start_urls": ["https://24fe-92-28-230-172.eu.ngrok.io/primitives/docs"], | ||
| "index_name": "radix_website_hf6d3bhd9_workos_vercel_app_co3q04we0u_pages", |
There was a problem hiding this comment.
We don't want to change the index since we use our own account for this.
algolia/config.json
Outdated
| "min_indexed_level": 1, | ||
| "selectors_exclude": ["[data-algolia-exclude]"], | ||
| "scrape_start_urls": false | ||
| "index_name": "radix_website_hf6d3bhd9_workos_vercel_app_co3q04we0u_pages", |
There was a problem hiding this comment.
We don't want to change the index since we use our own account for this.
package.json
Outdated
| "version": "0.0.0", | ||
| "private": true, | ||
| "packageManager": "pnpm@10.2.0", | ||
| "packageManager": "pnpm@10.12.1", |
There was a problem hiding this comment.
Please do not change this value. Ensure you are using the same version of pnpm locally as we are using in the repo.
algolia/.env.example
Outdated
| API_KEY= | ||
| APPLICATION_ID=CO3Q04WE0U | ||
| API_KEY=0715976de79c8c1bdb658b4189a605ff | ||
| NEXT_PUBLIC_ALGOLIA_INDEX_NAME=radix_website_hf6d3bhd9_workos_vercel_app_co3q04we0u_pages No newline at end of file |
.env.development
Outdated
| @@ -1 +1,3 @@ | |||
| NEXT_PUBLIC_ALGOLIA_INDEX_NAME=development_docs | |||
| NEXT_PUBLIC_ALGOLIA_INDEX_NAME=radix_website_hf6d3bhd9_workos_vercel_app_co3q04we0u_pages | |||
.env.development
Outdated
| ALGOLIA_APP_ID=CO3Q04WE0U | ||
| ALGOLIA_PUBLIC_API_KEY=0715976de79c8c1bdb658b4189a605ff No newline at end of file |
There was a problem hiding this comment.
| ALGOLIA_APP_ID=CO3Q04WE0U | |
| ALGOLIA_PUBLIC_API_KEY=0715976de79c8c1bdb658b4189a605ff |
.env.production
Outdated
| @@ -1 +1 @@ | |||
| NEXT_PUBLIC_ALGOLIA_INDEX_NAME=docs | |||
| NEXT_PUBLIC_ALGOLIA_INDEX_NAME=radix_website_hf6d3bhd9_workos_vercel_app_co3q04we0u_pages | |||
There was a problem hiding this comment.
Hi chaance,
I've addressed all feedback:
Functionality is fixed: The logic for the Algolia selectors has been corrected, and the search functionality is now working as expected in my testing environment.
All Reverts Complete: I have successfully reverted the index_name, start_urls, packageManager version, and all environment variables/API keys/IDs across all files as requested.
The search component will not function on this branch until the necessary secrets (API_KEY, APPLICATION_ID) are provided by your deployment environment and also update by your meta tag to allow the algolia to crawl the website.
The PR is now clean and ready for your final review and merge. Thanks!
|
We should not be hard coding or exposing API keys. I was unaware that we are doing this currently, but that's worth changing while we're addressing it here. |
|
@Praneshxo is attempting to deploy a commit to the WorkOS Team on Vercel. A member of the Team first needs to authorize it. |
2 participants
This pull request:
Preview Link :https://radixuittest.vercel.app/primitives/docs/overview/introduction
Closes #854