Repository navigation
test: wait on the accepted-connection event in the replacement-handshake test - #201
Open
salty-flower wants to merge 1 commit into
Open
salty-flower wants to merge 1 commit into
salty-flower wants to merge 1 commit into
Conversation
…ake test A two-second deadline made the regression fail under scheduler load.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancellation_while_replacement_startup_is_blocked_aborts_request_stateno longer fails spuriously on a loaded machine.Why: the test waited at most two seconds for the replacement connection to reach its blocked handshake. Under scheduler load (a parallel
cargo testnext to other builds), startup can take longer than that → the timeout fires → the test fails although the code under test behaved correctly. The test now awaits the accepted-connection event itself. That event always arrives in a correct run, and a real hang still surfaces through the test harness.What to check: that nothing else in the test relied on the two-second bound as an assertion.
Validation:
cargo test providers::codexpasses (427 tests);cargo fmt --checkis clean.🤖 Generated with Claude Code