Fix case-insensitive tool name lookup and remove duplicate entries#623
Merged
Fix case-insensitive tool name lookup and remove duplicate entries#623
Conversation
- Make toolNameMap lookups case-insensitive in extension.ts, workspaceHelpers.ts, logviewer and usage webviews - Normalize automaticTools sets to lowercase for case-insensitive .has() checks in maturityScoring.ts and usage webview - Remove duplicate capitalized keys from toolNames.json: 'Read', 'Write', 'Edit' - Remove duplicate capitalized entries from automaticTools.json: 'Read', 'Bash' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the duplicate entries introduced in #620 by making all tool name lookups case-insensitive, so capitalized variants like
"Read","Write","Edit","Bash"are handled automatically without needing separate JSON entries.Changes
Duplicate removal
toolNames.json: Removed"Read","Write","Edit"(duplicates of lowercase keys)automaticTools.json: Removed"Read"and"Bash"(duplicates of lowercase entries)Case-insensitive lookups
extension.ts:getUnknownTools()— checks both exact and lowercase key before reporting a tool as unknownworkspaceHelpers.ts:extractMcpServerName()— falls back totoolName.toLowerCase()lookupwebview/logviewer/main.tsandwebview/usage/main.ts:lookupToolName()— tries lowercase fallback before returning raw idmaturityScoring.ts: StoresAUTOMATIC_TOOL_SETwith lowercased keys; checks witht.toLowerCase()webview/usage/main.ts:AUTOMATIC_TOOL_SET_WVlikewise normalized; badge check usestool.toLowerCase()Fixes #619