Conversation
libbase.a was removed from !WIN32, but not from WIN32. Likely causing the build to fail on windows.
Commented out superfluous library entries that were causing build failures.
This reverts commit 8825655.
|
I will try to find some time to look at this. Can you confirm that the result is a statically linked build? On Linux:
On MacOS:
On Windows:
These programs will list any/all dynamic dependencies of the vsp executable. It should list only system libraries. For example, 3.49.0 on MacOS this gives: |
|
Here is the output of the .deb from the github build actions: I don't have access to a windows machine to test the windows build. Since the build scripts diverge for WIN32, that's where things might change. That said, I have no reason to believe the changes would result in shared libraries for any of the bundled dependencies, particularly for stepcode. |
|
When I was working with this, the primary difficulty I had was getting it to work with static libraries. The person who has been developing StepCode lately has not been testing the static library path, so there seemed to be several things broken about it. It is exactly where I expect things to go wrong. |
|
The Cmake flags are set to static libs, both with the default CMAKE flag and the stepcode specific CMAKE flag: I don't have a full CI pipeline to check to make sure that everything is being done correctly, so I'm relying on your build action, the fedpkg sandbox, and the self-test frameworks where applicable. I've built the STEPCode package so that it will be available as a Fedora package, and it does fail on aarch64. In the bundled case, would it throw an error if it builds a shared lib? |
|
In my experience, no. The problem I had may have been related to trying to force shared libs to OFF. For example, STEPCode builds the schema parser during the build process. It needs its own libraries to do that. When building with shared libs off, the schema parser may have failed to build. The next problem is when you search for the libraries to build VSP. If it finds the shared libraries instead of the static ones, it may use that. Letting it build the shared libraries may be a good solution -- let the STEPCode build and schema generation work as expected. Then we just have to make sure it has and finds the static libs when it builds VSP. |
This should fix everything. The last problem I fixed was the package names, which changed in the latest versions. Build tests work.