Skip to content

Change HtmxHeaderTagHelper.Headers to IDictionary<string, string> #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rameel merged 1 commit into from
Aug 9, 2026
Merged

Change HtmxHeaderTagHelper.Headers to IDictionary<string, string> #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Ramstack.HtmxToolkit/TagHelpers/HtmxHeaderJsonSerializerContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Ramstack.HtmxToolkit.TagHelpers;

[JsonSerializable(typeof(Dictionary<string, string>))]
[JsonSerializable(typeof(IDictionary<string, string>))]
[JsonSourceGenerationOptions(
WriteIndented = false,
GenerationMode = JsonSourceGenerationMode.Serialization)]
Expand Down
4 changes: 2 additions & 2 deletions src/Ramstack.HtmxToolkit/TagHelpers/HtmxHeaderTagHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,13 @@ public sealed class HtmxHeaderTagHelper : TagHelper
/// Gets or sets the <c>hx-header</c> attribute values.
/// </summary>
[HtmlAttributeName(HeadersDictionaryName, DictionaryAttributePrefix = HeadersPrefix)]
public Dictionary<string, string> Headers { get; set; } = new();
public IDictionary<string, string> Headers { get; set; } = new Dictionary<string, string>();

/// <inheritdoc />
public override Task ProcessAsync(TagHelperContext context, TagHelperOutput output)
{
var headers = new HtmlString(
JsonSerializer.Serialize(Headers, HtmxHeaderJsonSerializerContext.Default.DictionaryStringString));
JsonSerializer.Serialize(Headers, HtmxHeaderJsonSerializerContext.Default.IDictionaryStringString));

output.Attributes.SetAttribute(
new TagHelperAttribute("hx-headers", headers, HtmlAttributeValueStyle.SingleQuotes));
Expand Down
Loading