Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Ramstack.HtmxToolkit/TagHelpers/HtmxRequestTagHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ public override Task ProcessAsync(TagHelperContext context, TagHelperOutput outp
{
var info = HtmxRequestJsonSerializerContext.Default.HtmxRequestData;
var request = new HtmlString(JsonSerializer.Serialize(_request, info));
output.Attributes.SetAttribute(new TagHelperAttribute("hx-request", request));

output.Attributes.SetAttribute(
new TagHelperAttribute("hx-request", request, HtmlAttributeValueStyle.SingleQuotes));
}

return Task.CompletedTask;
Expand Down
11 changes: 11 additions & 0 deletions tests/Ramstack.HtmxToolkit.Tests/HtmxConfigTagHelperTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,17 @@ public async Task ProcessAsync_WithDefaults_SerializesEmptyObject()
Assert.That(GetContent(output), Is.EqualTo("{}"));
}

[Test]
public async Task ProcessAsync_UsesSingleQuotesForJsonAttribute()
{
var output = TestHelper.CreateTagHelperOutput();
var helper = new HtmxConfigTagHelper(new StubAntiforgery());

await helper.ProcessAsync(TestHelper.CreateTagHelperContext(), output);

Assert.That(output.Attributes["content"]!.ValueStyle, Is.EqualTo(HtmlAttributeValueStyle.SingleQuotes));
}

[Test]
public async Task ProcessAsync_SerializesConfiguredOptions()
{
Expand Down
18 changes: 18 additions & 0 deletions tests/Ramstack.HtmxToolkit.Tests/HtmxHeaderTagHelperTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.AspNetCore.Html;
using Microsoft.AspNetCore.Razor.TagHelpers;

namespace Ramstack.HtmxToolkit.Tests;

Expand Down Expand Up @@ -46,6 +47,23 @@ public void Headers_TreatsNamesAsCaseInsensitive()
Assert.That(helper.Headers["X-CUSTOM"], Is.EqualTo("second"));
}

[Test]
public async Task ProcessAsync_UsesSingleQuotesForJsonAttribute()
{
var output = TestHelper.CreateTagHelperOutput();
var helper = new HtmxHeaderTagHelper
{
Headers =
{
["X-Custom"] = "value"
}
};

await helper.ProcessAsync(TestHelper.CreateTagHelperContext(), output);

Assert.That(output.Attributes["hx-headers"]!.ValueStyle, Is.EqualTo(HtmlAttributeValueStyle.SingleQuotes));
}

[Test]
public async Task ProcessAsync_SerializesEmptyDictionary()
{
Expand Down
15 changes: 15 additions & 0 deletions tests/Ramstack.HtmxToolkit.Tests/HtmxRequestTagHelperTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.AspNetCore.Html;
using Microsoft.AspNetCore.Razor.TagHelpers;

namespace Ramstack.HtmxToolkit.Tests;

Expand Down Expand Up @@ -49,6 +50,20 @@ public async Task ProcessAsync_OmitsUnsetProperties()
Assert.That(json.ContainsKey("noHeaders"), Is.False);
}

[Test]
public async Task ProcessAsync_UsesSingleQuotesForJsonAttribute()
{
var output = TestHelper.CreateTagHelperOutput();
var helper = new HtmxRequestTagHelper
{
Timeout = 500
};

await helper.ProcessAsync(TestHelper.CreateTagHelperContext(), output);

Assert.That(output.Attributes["hx-request"]!.ValueStyle, Is.EqualTo(HtmlAttributeValueStyle.SingleQuotes));
}

[Test]
public async Task ProcessAsync_OmitsUnsetConfiguration()
{
Expand Down
18 changes: 18 additions & 0 deletions tests/Ramstack.HtmxToolkit.Tests/HtmxValsTagHelperTests.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using Microsoft.AspNetCore.Html;
using Microsoft.AspNetCore.Razor.TagHelpers;

namespace Ramstack.HtmxToolkit.Tests;

Expand Down Expand Up @@ -37,6 +38,23 @@ public async Task ProcessAsync_SerializesValues()
Assert.That(json["sort"].GetString(), Is.EqualTo("title"));
}

[Test]
public async Task ProcessAsync_UsesSingleQuotesForJsonAttribute()
{
var output = TestHelper.CreateTagHelperOutput();
var helper = new HtmxValsTagHelper
{
Values =
{
["sort"] = "title"
}
};

await helper.ProcessAsync(TestHelper.CreateTagHelperContext(), output);

Assert.That(output.Attributes["hx-vals"]!.ValueStyle, Is.EqualTo(HtmlAttributeValueStyle.SingleQuotes));
}

[Test]
public async Task ProcessAsync_OmitsEmptyDictionary()
{
Expand Down
Loading