fix(bash): validate workdir exists before spawning shell (#189)#190
Merged
fix(bash): validate workdir exists before spawning shell (#189)#190
Conversation
- Added realpath resolution and path normalization - Added directory existence validation with Instance.containsPath() fallback - Added comprehensive tests (20/20 pass) - Updated .fork-features/manifest.json Security improvements: - Rejects empty/whitespace workdir at Zod schema level - Resolves symlinks securely - Normalizes Windows paths - Enforces project boundary validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validates bash tool workdir parameter exists before spawning shell. Falls back to Instance.directory with warning log if LLM provides non-existent path.
Changes
Security
Testing
Fixes #189