Repository navigation
fix(evaluations): evaluator landing and page frame - #211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the evaluator experience, found while walking through a full
exercise by hand.
The evaluation queue had no page frame. It rendered as bare content in the
top-left corner, with no header, title or navigation. It now looks like every
other page. The queue itself is left reusable, since later slices embed it.
Evaluators landed on a page they are not allowed to see. Picking an exercise
sent everyone to the team report list, which evaluators are refused — so they
got an error instead of their work. Evaluators now go straight to their own
evaluation queue. Admins still land on the report list.
Test plan
Refs #45