LEDO-814: Try to correct broken workflows#21
Merged
Conversation
atwaddle-r7
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aims to restore failing GitHub Actions workflows by updating the CI Ruby/JRuby matrix and making small formatting/test adjustments to reduce cross-Ruby/JRuby differences.
Changes:
- Update CI to run against JRuby 9.4.
- Relax match reporter spec expectation to tolerate whitespace variations in
Hash#inspectoutput. - Apply small RuboCop-driven style cleanups in
Recog::Fingerprint#match.
Impact Analysis:
- Blast radius: low (CI configuration + specs;
fingerprint.rbchange appears style-only). - Data and contract effects: none identified from diff (no schema/payload changes).
- Rollback and test focus: rollback is straightforward (revert commit); focus on CI matrix runs (especially JRuby) and
spec/lib/recog/match_reporter_spec.rbstability across runtimes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Updates the CI Ruby matrix to include JRuby 9.4. |
lib/recog/fingerprint.rb |
RuboCop-style edits in fingerprint matching/interpolation guard logic. |
spec/lib/recog/match_reporter_spec.rb |
Makes the match output assertion more tolerant of whitespace differences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| describe '#report' do | ||
| it 'prints matches' do | ||
| expect(formatter).to receive(:success_message).with('MATCH: {"data"=>"a match"}') | ||
| expect(formatter).to receive(:success_message).with(a_string_matching(/\AMATCH: \{"data"\s*=>\s*"a match"\}\z/)) |
| fail-fast: false | ||
| matrix: | ||
| ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', 'jruby-9.2', 'jruby'] | ||
| ruby-version: ['2.5', '2.6', '2.7', '3.0', '3.1', 'jruby-9.4', 'jruby'] |
sbhuiyan-r7
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some changes to get workflows working again:
Motivation and Context
Fixing failing workflows (https://rapid7.atlassian.net/browse/LEDO-814)
How Has This Been Tested?
Tested locally, and verified that commit was passing
Types of changes
Checklist: