Alternative Dask-CloudProvider Azure Installation Command #457
Open
melodywang060 wants to merge 6 commits intomainfrom
Open
Alternative Dask-CloudProvider Azure Installation Command #457melodywang060 wants to merge 6 commits intomainfrom
melodywang060 wants to merge 6 commits intomainfrom
Conversation
jameslamb
requested changes
Oct 9, 2024
Member
jameslamb
left a comment
There was a problem hiding this comment.
Thanks for investigating this! Left some comments for your consideration.
In general, anywhere you see an installation requirement that uses shell characters, like these:
pip install dask[cloudprovider]
pip install pandas==2.*
pip install numpy>=1.23,<3.0.0a0
They should be wrapped in single quotes to prevent the shell from assigning special meaning to those characters.
If you see other cases like this in the docs, I'd support adding single quotes to them (does not need to be in this PR though).
source/cloud/azure/azure-vm-multi.md
Outdated
| $ pip install dask-cloudprovider[azure] | ||
| ``` | ||
|
|
||
| Try running `pip install "dask-cloudprovider[azure]"` instead if you encounter a `zsh: no matches found` error. |
Member
There was a problem hiding this comment.
Instead of adding another line to the docs, I think it'd be simpler to just add single quotes to the code sample above. That should always work, in any shell. Could you please do that instead?
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently when trying to install Dask-CloudProvider Azure, I am getting a

no matches founderror:Quick Fix
After some tweaking and exploration, I tried inserting quotation marks around the package name, and that worked.
Therefore, in this PR I propose adding a sentence in the docs that refers to this potential error and suggests users to add quotation marks if they encounter it.