Support git worktrees in RAPIDS script generation#716
Open
bdice wants to merge 1 commit into
Open
Conversation
vyasr
reviewed
Jun 5, 2026
Contributor
vyasr
left a comment
There was a problem hiding this comment.
Seems robust enough for the devcontainers use case.
vyasr
approved these changes
Jun 5, 2026
trxcllnt
requested changes
Jun 5, 2026
Collaborator
trxcllnt
left a comment
There was a problem hiding this comment.
Need to bump the feature version, otherwise looks fine to me. Are there any other places that check for -d .git that also need to be updated?
4c5f416 to
c42fa60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git -C <path> rev-parse --is-inside-work-treeinstead of testing for a.gitdirectory.gitis a file instead of a directoryrapids-build-utilsfrom26.8.4to26.8.5andutilsfrom26.8.1to26.8.2Motivation
This is necessary to support devcontainers that use git worktrees. Worktree checkouts store
.gitas a file pointing at the real git metadata, so the previous-d <repo>/.gitchecks treated valid worktree repos as missing. Inrapids-generate-scripts, that meant only aggregate/no-op scripts were generated.Testing
bash -npassed for the 10 modified shell scriptsgit diff --checkpassed.gitdirectory predicates in the reporapids-generate-scripts --repo rmmgeneratedbuild-rmmandtest-rmm-pythonbuild-all -j0passedtest-all-pythonpassed:1780 passed, 6 skipped