Release 0.8.0 - #115
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three review passes in one day, eighteen findings closed across PRs #90–#114.
The public API did not change shape —
composer bc-check --from=v0.7.0reportsno backwards-incompatible changes — but what the package says about a
document or an exchange changed a great deal, which is what makes this a minor
rather than a patch.
What an upgrader should know, in the order it will bite:
request.parameter.duplicaterequestBody,parameters,content,encoding,headersor subschema, a boolean written as a string, a schema carrying.nan/.inf, a parameter declared twice in one list,pathsthat yield no operation$refsiblings follow the dialectallOfcontentmap is matched by specificity*/*above an exact media type no longer wins/petsand/pets/are different operationsAccept,Content-Type,Authorizationheader parameters are ignored, and a 3.0requestBodyon GET/HEAD/DELETE too$refis resolved only where it is a keywordexamplecarrying a$refmember is kept as written instead of being substituted or refusedContractExceptionmarks every exception the package raisescatchcan name one typeConsumers:
rasuvaeff/property-testing-openapiis green against this branch(709 tests) as of rasuvaeff/property-testing-openapi#87, and its constraint is
bumped to
^0.8in a follow-up once this is tagged.Verification:
composer buildgreen (718 tests, 2 771 assertions),composer rectorclean,make audit-packageclean,composer bc-check --from=v0.7.0clean,
composer mutationMSI 93% against the gate of 92, corpus current(
bin/record-openapi-corpus --check).