Write down three divergences instead of changing behaviour - #122
Merged
Conversation
All three come from the full-cycle review, and none of them changes a verdict. The one worth the paragraph is the delimiter: both specifications say `|` and space MUST be percent-encoded inside a value, so `?ids=a%7Cb` is one element containing a pipe. This package folds the encoded form into the delimiter and reads two. Fixing that would buy agreement with the text at the cost of agreement with every PHP application that decodes and then splits — and agreeing with the application is what a validator is for. `deepObject` is not in the same position: there, PHP folds the brackets too.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class B of the full-cycle review (
docs/reviews/review-openapi-contract-2026-09-06-full-cycle.md): divergences from the specification with no observable harm. Documented, not fixed — deliberately.pipeDelimited/spaceDelimitedvalue|and space MUST be percent-encoded inside a value, so?ids=a%7Cbis the single elementa|bnameorinexampleandexamplestogetherThe delimiter one is the interesting call.
parse_str('ids=a%7Cb')gives{"ids":"a|b"}, and a PHP application that decodes and then splits reads two elements — exactly as this package does. Conforming to the text would make the validator disagree with the application it validates for, which is the one thing a validator must not do. The cost is real and now stated: a value containing the delimiter cannot be expressed at all.deepObjectwas checked and is not in this list:f%5Ba%5D=1andf[a]=1are one parameter here and in PHP's own parsing (probedelimiters3.php).No source changes;
composer buildandbin/package-auditgreen.