Require the contract 0.8 line - #88
Merged
Merged
Conversation
0.8.0 refuses documents 0.7 accepted and reads several things differently — $ref siblings by dialect, a content map by specificity, a trailing slash as part of the path, a repeated parameter as a violation. This package's suite is green on both, and was already verified against that branch before it was tagged; the constraint moves so that --prefer-lowest exercises the compiler these tests are written against.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rasuvaeff/openapi-contractv0.8.0 is out — three review passes, eighteenfindings, and a compiler that refuses documents 0.7 accepted.
This package needed no code change for it: #87 already made the suite green
against that branch before it was tagged, by building the deliberately
malformed documents as hand-built
Operations instead of compiling them. Theconstraint moves so that
--prefer-lowestinstalls the compiler these testsare actually written against, and so the
Contract dev-masterjob comparesagainst something ahead of the floor rather than two lines ahead of it.
Verification:
composer buildgreen (709 tests, 29 491 assertions) withv0.8.0 installed.