Accept the contract 0.9 line - #89
Merged
Merged
Conversation
0.9 narrows the contract's public surface — `Operation::__construct()` is `@internal`, and the byte budgets moved from `Contract::MAX_*` constants to a `Limits` object — without changing how a document compiles or how a message is judged. This suite reads neither constant, and its hand-built operations still work: `@internal` is a docblock, and building them is what this package needs to reach the generator's refusals at all. Both lines stay supported rather than replaced, because the suite passes against both: 709 green on 0.8 and on the contract's master.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rasuvaeff/openapi-contract0.9 settles the three decisions a 1.0 tag would have frozen (openapi-contract#119):Operation::__construct()is@internal,Contract::MAX_DOCUMENT_BYTES/MAX_MESSAGE_BODY_BYTESgive way to aLimitsobject, andCompiledParameterdeclares its variance. Nothing about how documents compile or how messages are judged changed.Widened rather than replaced —
^0.8 || ^0.9— because this suite passes against both lines (709 tests green on released 0.8 and on the contract's master), so pinning it forward would drop support for no reason.Nothing else needs changing here: the package reads neither removed constant, and the hand-built
Operations introduced in #87 still work —@internalis a docblock, and constructing them is the only way this package can reach the generator's refusals now that the compiler rejects malformed documents.