Docs workspace on the current satellites, rector in CI, two generator fixes - #115
Merged
Conversation
… fixes - docs/.api-workspace pins move to the lines that exist (-psalm ^0.8, -phpstan ^0.5, -phpunit ^0.3, -testo ^0.3, engine 0.9.0) and the lock is committed, so the pages in the repository and on the site come from one install. docs.yml runs `composer outdated --direct --strict` there: a satellite release the pins do not reach is a red build, not a stale page. - static-analysis.yml runs `composer rector` in the Psalm job (part of release-check, checked by nobody before a tag until now). - reflect-rules.php counts only constants named *IDENTIFIER — the php-parser attribute `understudy.receiverOfCall` was rendered as a sixth rule; generate-api.mjs labels a trait as "Trait" instead of "undefined". - API pages regenerated from the new workspace (satellites at v0.3.1 / v0.3.0 / v0.8.1 / v0.5.1, engine v0.9.0).
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
docs/.api-workspace/composer.jsonpinned the satellites to^0.2/^0.1— a caret on 0.x pins a minor — so the site documentedunderstudy-psalm0.2.0 while 0.8.x was out. Pins move to-psalm ^0.8,-phpstan ^0.5,-phpunit ^0.3,-testo ^0.3(engine path version0.9.0), the lock is committed (.gitignorenegation) so the committed pages and the deployed site come from one install, anddocs.ymlrunscomposer outdated --direct --strictin the workspace — a satellite release the pins do not reach is a red build now. The workflow comments that promised «never more than a week behind» say what actually happens.composer rectoras a step of the existingPsalmjob instatic-analysis.yml(same job → the required check keeps its name). Same change merged in the four satellites.reflect-rules.phpmatched any literal starting withunderstudy., so the php-parser attributeunderstudy.receiverOfCall(ClosureShape) became a sixth "identifier" on/api/rules; it counts only constants named*IDENTIFIERnow.generate-api.mjshad no label for a trait, so the PHPUnit adapter's page was headed «undefined».docs/src/api/**regenerated: satellites at v0.3.1 / v0.3.0 / v0.8.1 / v0.5.1, engine v0.9.0, five identifiers.Verification
npm run docs:checkpassed (34@apitypes, 5 identifiers, every page reachable),composer outdated --direct --strictin the workspace exits 0.