Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the reduced viewer-demo case requested in MakerPnP#26. It checks that escaped comment delimiters preserve the following macro, aperture definition and flash, with both physical lines and a compact command stream.
The reported failure comes from unescaped
*and%in G04 strings. The original reduced fixture fails with lost command boundaries; escaping those characters passes without changing parser behavior. Gerber specification sections 3.4.3 and 4.1 require these escapes. The full demo correction is MakerPnP/gerber-viewer#16.This PR targets the existing upstream PR's source branch. Direct push was rejected because that branch is locked. This test commit can be integrated after the lock is addressed.
Validation:
cargo test --offline --all-features: 58 passed.cargo fmt --all -- --check: passed.cargo clippy --offline --all-targets --all-features -- -D warnings -A clippy::blocks_in_conditions: passed. The allowed lint predates this change.