Use verified master pushes for cached CI and TestFlight - #95
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub now makes cache tokens read-only for pull_request_target events, even after an owner merge. Use the normal master push event with a read-only verification job that checks GitHub's PR API for the exact merge SHA, merged state, owner merger, base repository, and master target before tests or TestFlight can run.
This restores normal build-cache writes without overriding security defaults or relaxing lint rules. Direct pushes and open/unmerged PRs skip the test and publishing jobs; every checkout uses the pushed SHA. Owner identity checks remain server-side on every job.
Validation: the API verifier accepted the actual owner merge and rejected a direct-push commit. Three verifier tests and six workflow-policy tests passed, and actionlint passed. The previous hosted run's full unit-test job is green and its TestFlight build is in progress.