Skip to content

Fix UB in number tokenizer: use pointer arithmetic instead of derefer… #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rayokota merged 1 commit into from
Jun 15, 2026
Merged

Fix UB in number tokenizer: use pointer arithmetic instead of derefer… #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/jsonata/Tokenizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,11 +372,13 @@ std::unique_ptr<Tokenizer::Token> Tokenizer::next(bool prefix) {
{
static const std::regex numregex(
"^-?(0|([1-9][0-9]*))(\\.[0-9]+)?([Ee][-+]?[0-9]+)?");
// Use byte offsets to get iterators into the original string without copying
auto byteStart = path_.cbegin() + static_cast<std::string::difference_type>(byte_offsets_[position_]);
auto byteEnd = path_.cend();
// Use byte offsets to get pointers into the original string without copying.
// Use pointer arithmetic on data() rather than dereferencing iterators:
// &*path_.cend() dereferences a past-the-end iterator
const char* byteStart = path_.data() + byte_offsets_[position_];
const char* byteEnd = path_.data() + path_.size();
std::cmatch match;
if (std::regex_search(&*byteStart, &*byteEnd, match, numregex) &&
if (std::regex_search(byteStart, byteEnd, match, numregex) &&
match.position() == 0) {
std::string numStr = match.str(0);
double num = std::stod(numStr);
Expand Down
Loading