Skip to content

feat: add global scrolbar style #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanchkrabrty merged 1 commit into from
Jun 8, 2026
Merged

feat: add global scrolbar style #833

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/raystack/styles/reset.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
/* Resets for button */

button,
[type='button'],
[type='reset'],
[type='submit'] {
[type="button"],
[type="reset"],
[type="submit"] {
-webkit-appearance: button;
appearance: button;
appearance: button;
Comment on lines 7 to +8

@coderabbitai coderabbitai Bot Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

What is the correct modern CSS value for the appearance property on button elements?

💡 Result:

The modern, standards-based CSS value is appearance: none; to remove native/platform styling, while appearance: auto; preserves the browser’s native button appearance. If you specifically want to force a “button-like” widget appearance via appearance’s legacy keywords, the value appearance: button; exists, but MDN notes these older values behave like auto and says to use auto instead.[1]

Citations:

Update appearance: button to appearance: auto in reset.css

MDN recommends using appearance: auto (legacy appearance: button keywords should be avoided even if they behave similarly). Update both the prefixed and unprefixed declarations.

🔧 Proposed fix 
-  -webkit-appearance: button;
-  appearance: button;
+  -webkit-appearance: auto;
+  appearance: auto;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
-webkit-appearance: button;
appearance: button;
appearance: button;
-webkit-appearance: auto;
appearance: auto;
🧰 Tools
🪛 Stylelint (17.12.0)

[error] 8-8: Expected "button" to be "auto" (declaration-property-value-keyword-no-deprecated)

(declaration-property-value-keyword-no-deprecated)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/raystack/styles/reset.css` around lines 7 - 8, Replace the legacy
"button" value for the appearance declarations: change both "-webkit-appearance:
button;" and "appearance: button;" to use "auto" (i.e., "-webkit-appearance:
auto;" and "appearance: auto;") so the reset.css uses the recommended appearance
value.

Source: Linters/SAST tools

background-color: transparent;
background-image: none;
}

/* Global native scrollbar styling — uses the Baseline standard scrollbar
properties (scrollbar-width / scrollbar-color), supported across Chrome,
Safari and Firefox. Note: scrollbar-width is keyword-only (no exact px) and
setting scrollbar-color opts out of the macOS overlay/auto-hide scrollbar.
Use the <ScrollArea> component where auto-hide / hover-grow polish matters. */
* {
scrollbar-width: thin;
scrollbar-color: var(--rs-color-overlay-base-a5) transparent;
}
Loading