Repository navigation
feat: export the props type of every component - #965
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 50 files. (50 skipped… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check The PR satisfies the coding requirements in [ #877]. It exports prop types from component barrels and frompackages/react/index.tsx. The required examples includeButtonProps,CheckboxPropswith …Out of Scope Changes check The changes stay within the linked issue scope. Component-barrel exports, the package-root exports, prop-type corrections, the export verification guidance, and the documentation explain or enforce co… Description check The description clearly explains the component prop type exports, related renames, call-site type updates, verification guidance, and linked issue. Title check The title is concise and accurately describes the primary change: exporting every component's props type.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 50 files. (50 skipped: 3 unsupported, 47 over the file limit.)
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
commit: |
Shreyag02
changed the title
Shreyag02
removed this pull request from stack #972
October 12, 2026 07:57
# Conflicts: # packages/react/index.tsx
rohanchkrabrty
approved these changes
Oct 15, 2026
# Conflicts: # packages/react/components/radio/radio.tsx
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@raystack/apsara. Root parts use<Component>Props(TabsProps,CheckboxProps), asChatPanelPropsandPromptInputPropsalready did. Parts keep their names (TabsTabProps,CheckboxGroupProps).RangePickerSlotPropsis exported next toDatePickerSlotProps.AccordionPropsandRadioGroupPropskeep theValuetype parameter from feat: [accordion, radio] add generic value types #957, for exampleRadioGroupProps<Plan>.BoxPropstoFlexProps,ToolbarPropstoDataViewToolbarProps,DisplayControlsPropstoDataViewDisplayControlsProps,DisplaySettingsPropstoDataTableDisplayControlsProps,VirtualizedContentPropstoDataTableVirtualizedContentPropsandSidebarNavigationGroupPropstoSidebarGroupProps. None of these names could be imported before.refonCommand.Content,closeLabelonDrawer.Content, andchildrenonDataTable,DataViewandDataView.Toolbar.Tooltip.Triggertakes theTooltipTriggerPropsit declares instead of the Base UI props. Each exported type is what its part accepts.add-new-componentskill checks that a new component's props types are listed indist/index.d.tsafter the build.AGENTS.mdsays to export them with the component.ComponentProps<typeof Tabs.List>for them.Closes #877