ci: Place release configuration in a separate directory#54
ci: Place release configuration in a separate directory#54tomasz-blasz merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the release automation so the semantic-release toolchain is isolated under .github/release rather than being installed from the repository root.
Changes:
- Removed root
package.jsonand introduced a dedicated.github/release/package.json(with updated semantic-release dependencies). - Updated the GitHub Actions release workflow to install and run semantic-release from
.github/releaseusing an explicit config file. - Updated the release packaging script to strip
.githubfrom generated release tarballs.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes root-level Node devDependencies previously used for release tooling. |
| .github/workflows/release.yml | Installs/runs semantic-release from .github/release instead of repo root. |
| .github/scripts/mk-release-package.sh | Adjusts arg parsing and removes .github from the packaged artifact. |
| .github/release/releaserc.json | Adds semantic-release configuration under .github/release. |
| .github/release/package.json | Adds a dedicated package manifest for release tooling dependencies. |
| .github/release/package-lock.json | Updates the lockfile for the dedicated release toolchain dependency set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ed5629e to
2522641
Compare
2522641 to
775da87
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/scripts/mk-release-package.sh:30
- The argument-parsing loop condition
while [[ ! -z $1 ]]; dois unsafe when no args are provided or when$1expands to an empty string, because the test can be mis-parsed (andshiftwill then fail underset -e). Prefer a robust pattern likewhile (( $# )); doorwhile [[ -n ${1:-} ]]; do, and quote parameter expansions inside[[ ... ]]to avoid operator-like values being misinterpreted.
while [[ ! -z $1 ]]; do
case $1 in
--package) package="$2"; shift;;
--version) version="$2"; shift;;
--subpath) sub_path="$2"; shift;;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 0.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.