Skip to content

ci: Place release configuration in a separate directory#54

Merged
tomasz-blasz merged 2 commits intomainfrom
topic/separate-release-process
Mar 6, 2026
Merged

ci: Place release configuration in a separate directory#54
tomasz-blasz merged 2 commits intomainfrom
topic/separate-release-process

Conversation

@tomasz-blasz
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 5, 2026 15:48
@tomasz-blasz tomasz-blasz changed the title ci: Separate release process ci: Place release configuration in a separate directory Mar 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the release automation so the semantic-release toolchain is isolated under .github/release rather than being installed from the repository root.

Changes:

  • Removed root package.json and introduced a dedicated .github/release/package.json (with updated semantic-release dependencies).
  • Updated the GitHub Actions release workflow to install and run semantic-release from .github/release using an explicit config file.
  • Updated the release packaging script to strip .github from generated release tarballs.

Reviewed changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
package.json Removes root-level Node devDependencies previously used for release tooling.
.github/workflows/release.yml Installs/runs semantic-release from .github/release instead of repo root.
.github/scripts/mk-release-package.sh Adjusts arg parsing and removes .github from the packaged artifact.
.github/release/releaserc.json Adds semantic-release configuration under .github/release.
.github/release/package.json Adds a dedicated package manifest for release tooling dependencies.
.github/release/package-lock.json Updates the lockfile for the dedicated release toolchain dependency set.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz force-pushed the topic/separate-release-process branch from ed5629e to 2522641 Compare March 6, 2026 09:00
Copilot AI review requested due to automatic review settings March 6, 2026 09:03
@tomasz-blasz tomasz-blasz force-pushed the topic/separate-release-process branch from 2522641 to 775da87 Compare March 6, 2026 09:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

.github/scripts/mk-release-package.sh:30

  • The argument-parsing loop condition while [[ ! -z $1 ]]; do is unsafe when no args are provided or when $1 expands to an empty string, because the test can be mis-parsed (and shift will then fail under set -e). Prefer a robust pattern like while (( $# )); do or while [[ -n ${1:-} ]]; do, and quote parameter expansions inside [[ ... ]] to avoid operator-like values being misinterpreted.
while [[ ! -z $1 ]]; do
  case $1 in
  --package) package="$2"; shift;;
  --version) version="$2"; shift;;
  --subpath) sub_path="$2"; shift;;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tomasz-blasz tomasz-blasz merged commit c152ff0 into main Mar 6, 2026
16 checks passed
@tomasz-blasz tomasz-blasz deleted the topic/separate-release-process branch March 6, 2026 10:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
@tomasz-blasz
Copy link
Contributor Author

🎉 This PR is included in version 0.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants