fix: Remove FetchContent for the Transport#55
Merged
tomasz-blasz merged 1 commit intomainfrom Mar 6, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the CMake FetchContent-based fallback for acquiring FireboltTransport and switches the build to require an installed FireboltTransport package.
Changes:
- Removed FetchContent usage and Transport version-selection logic from the top-level CMake configuration.
- Dropped the custom
check_version_compatibility()helper fromcmake/version.cmake. - Documented the breaking build-system change in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
cmake/version.cmake |
Removes the now-unused version compatibility helper. |
CMakeLists.txt |
Stops fetching Transport and requires dependencies via find_package(). |
CHANGELOG.md |
Adds a breaking-change note about removing FetchContent. |
.transport.version |
Bumps Transport version value, though it is no longer consumed by the build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tomasz-blasz
force-pushed
the
topic/transport-must-be-installed
branch
from
1a2759b to
8e90a5b
Compare
vladimir-rangelov
approved these changes
Mar 6, 2026
Contributor
Author
|
🎉 This PR is included in version 0.5.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.