RDK-55826: Implement T2 Eventing in Network Manager Plugin by gururaajar · Pull Request #282 · rdkcentral/networkmanager

gururaajar · 2026-03-02T01:49:35Z

Reason for Change: Added T2 marker for the identified T1 telemetry markers
Test Procedure: Check whether the T2 events are received.
Priority: P1
Risks: Medium
Signed-off-by: Gururaaja ESRGururaja_ErodeSriranganRamlingham@comcast.com

Reason for Change: Added T2 marker for the identified T1 telemetry markers Test Procedure: Check whether the T2 events are received in the elk. Priority: P1 Risks: Medium Signed-off-by: Gururaaja ESR<Gururaja_ErodeSriranganRamlingham@comcast.com>

…r into topic/RDK-55826

Copilot

Pull request overview

Adds T2 telemetry (eventing) support to the NetworkManager plugin to emit additional markers for key connectivity/WiFi lifecycle signals and related diagnostics.

Changes:

Introduces T2 initialization and a logTelemetry() helper, and emits new T2 events for public IP, interface changes, internet status, WiFi state, and error scenarios.
Adds gateway MAC discovery utilities (via NetworkManager active connection + /proc/net/arp) and reports the MAC when IP is acquired.
Extends CMake to optionally enable and link against the T2 telemetry dependency.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
plugin/gnome/NetworkManagerGnomeWIFI.cpp	Emits telemetry when SSID input is empty.
plugin/gnome/NetworkManagerGnomeUtils.h	Declares new helper APIs for resolving gateway MAC.
plugin/gnome/NetworkManagerGnomeUtils.cpp	Implements gateway MAC resolution and retrieval from active connections.
plugin/gnome/NetworkManagerGnomeEvents.cpp	Hooks gateway MAC telemetry emission after IPv4 acquisition with caching.
plugin/NetworkManagerImplementation.h	Declares telemetry helper and adds conditional telemetry include.
plugin/NetworkManagerImplementation.cpp	Initializes T2 and emits multiple new telemetry events across state transitions.
plugin/CMakeLists.txt	Adds T2 dependency discovery/defines/linking for plugin targets.
CMakeLists.txt	Adds top-level `USE_TELEMETRY` option and T2 discovery/defines.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

CMakeLists.txt

plugin/NetworkManagerImplementation.h

plugin/NetworkManagerImplementation.cpp

plugin/gnome/NetworkManagerGnomeWIFI.cpp

plugin/gnome/NetworkManagerGnomeUtils.cpp

plugin/gnome/NetworkManagerGnomeEvents.cpp

plugin/NetworkManagerImplementation.cpp

…r into topic/RDK-55826

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tools/upnp/CMakeLists.txt

plugin/NetworkManagerImplementation.cpp

CMakeLists.txt

…r into topic/RDK-55826

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-03T03:08:52Z

plugin/NetworkManagerImplementation.cpp

+#if USE_TELEMETRY
+                if(ipversion == "IPv4")
+                {
+                    NMLOG_INFO("****** GURU: sending T2 event for NM_PUBLIC_IPV4 = %s ******", ipaddress.c_str());


This INFO log prints the device public IPv4 address, which can be sensitive/PII in production logs. Consider removing the IP from the log (or redact it) and/or lowering to DEBUG; the telemetry event already carries the value.

Suggested change

NMLOG_INFO("****** GURU: sending T2 event for NM_PUBLIC_IPV4 = %s ******", ipaddress.c_str());

NMLOG_INFO("****** GURU: sending T2 event for NM_PUBLIC_IPV4 ******");

plugin/NetworkManagerImplementation.cpp

Copilot · 2026-03-03T03:08:52Z

plugin/gnome/NetworkManagerGnomeUtils.cpp

+                if (iss >> ip >> hwType >> flags >> hwAddr) {
+                    if (ip == gatewayIp && hwAddr != "00:00:00:00:00:00") {
+                        mac = hwAddr;
+                        NMLOG_INFO("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str());


This function logs the resolved gateway MAC at INFO level. MAC addresses are typically treated as sensitive identifiers; consider lowering this to DEBUG and/or avoid logging the full MAC unless needed for diagnostics.

Suggested change

NMLOG_INFO("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str());

NMLOG_DEBUG("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str());

Copilot · 2026-03-03T03:08:53Z

plugin/gnome/NetworkManagerGnomeEvents.cpp

+                                    NMLOG_INFO("******** GURU: gatewayMacCache[%s] : %s ********", ifname.c_str(), gatewayMacCache[ifname].c_str());
+#if USE_TELEMETRY
+                                    NMLOG_INFO("******** GURU: connected - Gateway MAC: %s ********", gatewayMac.c_str());
+                                    _instance->logTelemetry("NM_GW_MAC", gatewayMac);


_instance->logTelemetry(...) is called without checking _instance != nullptr, while other callbacks in this file guard _instance first. During shutdown _instance is set to nullptr (see other uses below), so this can dereference null from the event thread. Add the same _instance != nullptr guard before calling logTelemetry.

Suggested change

_instance->logTelemetry("NM_GW_MAC", gatewayMac);

if (_instance != nullptr) {

_instance->logTelemetry("NM_GW_MAC", gatewayMac);

}

…r into topic/RDK-55826

bpunnuru · 2026-03-03T16:23:38Z

plugin/NetworkManagerImplementation.cpp

            _notificationLock.Lock();
            NMLOG_INFO("Posting onWiFiStateChange (%d)", state);
+#if USE_TELEMETRY
+            string stateStr = Core::EnumerateType<Exchange::INetworkManager::WiFiState>(state).Data();


log always, dont need to check for state.

bpunnuru · 2026-03-03T16:32:12Z

plugin/NetworkManagerImplementation.cpp

+               prevState != Exchange::INetworkManager::INTERNET_NOT_AVAILABLE)
+            {
+                NMLOG_INFO("NM_ETHERNET_FAILED = Ethernet is down, no internet");
+                logTelemetry("NM_ETHERNET_FAILED", "Ethernet is down, no internet");


change the marker name to clearly indicate ethernet connectivity failed.

gururaajar added 23 commits February 20, 2026 17:40

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

186f0d8

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

83fcf38

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

c12ec05

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

2ae7116

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

d9ece30

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

f8c8374

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

d489419

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

d922d3c

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

ec96f54

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

5e4741a

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

9675698

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

8c8dd0b

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

95e646e

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

e276f75

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

29db318

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

ec68798

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

10e5403

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

689d218

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

a059df8

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

e067d31

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

d0c864f

…r into topic/RDK-55826

gururaajar requested a review from a team as a code owner March 2, 2026 01:49

Copilot AI review requested due to automatic review settings March 2, 2026 01:49

Copilot started reviewing on behalf of gururaajar March 2, 2026 01:50 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

gururaajar added 3 commits March 2, 2026 15:14

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

9eb1f93

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

06ec81a

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

9f5b815

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

c2000ba

…r into topic/RDK-55826

Copilot AI review requested due to automatic review settings March 2, 2026 20:22

Copilot started reviewing on behalf of gururaajar March 2, 2026 20:22 View session

Copilot AI reviewed Mar 2, 2026

View reviewed changes

tools/upnp/CMakeLists.txt Outdated Show resolved Hide resolved

plugin/NetworkManagerImplementation.cpp Outdated Show resolved Hide resolved

CMakeLists.txt Outdated Show resolved Hide resolved

gururaajar added 4 commits March 2, 2026 15:31

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

51a0569

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

98b2003

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

66785df

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

5a1bb0c

…r into topic/RDK-55826

Copilot AI review requested due to automatic review settings March 3, 2026 03:04

Copilot started reviewing on behalf of gururaajar March 3, 2026 03:05 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

gururaajar added 2 commits March 3, 2026 10:45

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

a3008ea

…r into topic/RDK-55826

Merge branch 'topic/RDK-55826' of github.com:rdkcentral/networkmanage…

089419d

…r into topic/RDK-55826

bpunnuru reviewed Mar 3, 2026

View reviewed changes

	NMLOG_INFO("**** GURU: sending T2 event for NM_PUBLIC_IPV4 = %s ****", ipaddress.c_str());
	NMLOG_INFO("**** GURU: sending T2 event for NM_PUBLIC_IPV4 ****");

	NMLOG_INFO("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str());
	NMLOG_DEBUG("Resolved gateway IP %s to MAC %s", gatewayIp.c_str(), mac.c_str());

Conversation

gururaajar commented Mar 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

bpunnuru Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

bpunnuru Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants