Skip to content

RDKB-64757 : Remotedebugger debug.txt getting appended while repeatedly query same issueype #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhinavpv28 wants to merge 13 commits into
base: develop
Choose a base branch
from
+15 −10
Open

RDKB-64757 : Remotedebugger debug.txt getting appended while repeatedly query same issueype #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
314280a
Update rrdRunCmdThread.c
Abhinavpv28 Apr 29, 2026
d80af78
Update rrdRunCmdThread.c
Abhinavpv28 May 2, 2026
39b2e5c
Update rrdRunCmdThread.c
Abhinavpv28 May 2, 2026
02ad766
Fix format-truncation: increase remoteDebuggerServiceStr buffer to BU…
Copilot May 2, 2026
b01379f
Delete src/unittest/UTJson/device.properties
Abhinavpv28 May 4, 2026
f717399
Delete .gitignore
Abhinavpv28 May 4, 2026
39991ed
Update rrdRunCmdThread.c
Abhinavpv28 May 5, 2026
d01b8e6
Update L2-tests.yml
Abhinavpv28 May 5, 2026
cf98df3
Update rrdRunCmdThread.c
Abhinavpv28 May 5, 2026
2133306
Update rrdRunCmdThread.c
Abhinavpv28 May 5, 2026
be60956
Update L2-tests.yml
Abhinavpv28 May 5, 2026
a2844ad
Update rrdRunCmdThread.c
Abhinavpv28 May 5, 2026
ff5fda3
Remove error handling for epoch time retrieval
Abhinavpv28 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 14 additions & 10 deletions src/rrdRunCmdThread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ bool executeCommands(issueData *cmdinfo)
char pathname[BUF_LEN_256] = {'\0'};
char *outdirpath = NULL;
char finalOutFile[BUF_LEN_256] = {'\0'};
char remoteDebuggerServiceStr[BUF_LEN_256] = {'\0'};
char remoteDebuggerServiceStr[BUF_LEN_512] = {'\0'};
char *printbuffer = NULL;
FILE *filePointer;
const char *remoteDebuggerPrefix = "remote_debugger_";
Expand Down Expand Up @@ -357,7 +357,7 @@ bool executeCommands(issueData *cmdinfo)
strncat(finalOutFile,RRD_OUTPUT_FILE, strlen(RRD_OUTPUT_FILE) + 1);

/* Open debug_output.txt file*/
filePointer = fopen(finalOutFile, "a+");
filePointer = fopen(finalOutFile, "w+");
if (filePointer == NULL)
{
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Unable to Open File:%s\n",__FUNCTION__,__LINE__,finalOutFile);
Expand All @@ -376,21 +376,25 @@ bool executeCommands(issueData *cmdinfo)

/*Executing Commands using systemd-run*/
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Executing following commands using systemd-run:\n \"%s\"\n",__FUNCTION__,__LINE__,cmdData->command);
time_t epochTime = time(NULL);
if (epochTime == ((time_t)-1))
{
RDK_LOG(RDK_LOG_ERROR, LOG_REMDEBUG, "[%s:%d]: Failed to get epoch time\n", __FUNCTION__, __LINE__);
Comment thread
Abhinavpv28 marked this conversation as resolved.
Comment thread
Abhinavpv28 marked this conversation as resolved.
Comment thread
Abhinavpv28 marked this conversation as resolved.
Comment thread
Abhinavpv28 marked this conversation as resolved.
}

strncpy(remoteDebuggerServiceStr, remoteDebuggerPrefix, sizeof(remoteDebuggerServiceStr) - 1);
remoteDebuggerServiceStr[sizeof(remoteDebuggerServiceStr) - 1] = '\0';
strncat(remoteDebuggerServiceStr, cmdData->rfcvalue, sizeof(remoteDebuggerServiceStr) - strlen(remoteDebuggerServiceStr) - 1);
snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr),"%s%s%ld", remoteDebuggerPrefix, cmdData->rfcvalue, (long)epochTime);
//snprintf(remoteDebuggerServiceStr, sizeof(remoteDebuggerServiceStr), "%s%s", remoteDebuggerPrefix, dirname);
Comment thread
Abhinavpv28 marked this conversation as resolved.
Comment thread
Abhinavpv28 marked this conversation as resolved.

removeQuotes(cmdData->command);

FILE *systemdfp = v_secure_popen("r", "systemd-run -r --unit=%s --service-type=oneshot -p RemainAfterExit=yes /bin/sh -c %s", remoteDebuggerServiceStr, cmdData->command);
if(systemdfp == NULL)
{
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: Starting %s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
}
else
{
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Starting %s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
copyDebugLogDestFile(systemdfp, filePointer);
v_secure_pclose(systemdfp);
}
Expand All @@ -400,11 +404,11 @@ bool executeCommands(issueData *cmdinfo)
FILE *journalctlfp = v_secure_popen("r", "journalctl -a -u %s", remoteDebuggerServiceStr);
if(journalctlfp == NULL)
{
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service failed!!!\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
RDK_LOG(RDK_LOG_ERROR,LOG_REMDEBUG,"[%s:%d]: journalctl %s service failed!!!\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
}
else
{
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: journalctl remote_debugger_%s service success...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
Comment thread
Abhinavpv28 marked this conversation as resolved.
copyDebugLogDestFile(journalctlfp, filePointer);
v_secure_pclose(journalctlfp);
}
Expand All @@ -417,7 +421,7 @@ bool executeCommands(issueData *cmdinfo)
sleep(cmdData->timeout);

/*Stop or Reset runtime service for issue*/
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping remote_debugger_%s service...\n",__FUNCTION__,__LINE__,cmdData->rfcvalue);
RDK_LOG(RDK_LOG_INFO,LOG_REMDEBUG,"[%s:%d]: Stopping %s service...\n",__FUNCTION__,__LINE__,remoteDebuggerServiceStr);
#if !defined(GTEST_ENABLE)
v_secure_system("systemctl stop %s", remoteDebuggerServiceStr);
free(cmdData->rfcvalue); // free rfcvalue received from RRDEventThreadFunc
Expand Down
1 change: 1 addition & 0 deletions src/rrdRunCmdThread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ extern "C"
#endif
#define RRD_OUTPUT_FILE "debug_outputs.txt"
#define BUF_LEN_256 256
#define BUF_LEN_512 512

/*Public Function*/
void initCache(void);
Expand Down
Loading