RDKEMW-10467: Fix Invalid time values caused by drift by shivabhaskar · Pull Request #212 · rdkcentral/telemetry

shivabhaskar · 2025-11-19T11:46:54Z

Reason for Change: Changing CLOCK_REALTIME to CLOCK_MONOTONIC to avoid clock drifts impact in the calculations
Test Procedure: When Telemetry report generation is in progress change the time. The processing time should have a valid value
Risks: Low
Priority: P1

Copilot

Pull Request Overview

This PR fixes invalid time values in telemetry report generation caused by system clock drift by changing timing measurements from CLOCK_REALTIME to CLOCK_MONOTONIC.

Changed all elapsed time measurements from CLOCK_REALTIME to CLOCK_MONOTONIC to prevent clock drift from affecting duration calculations
Improved log messages in profilexconf.c for better clarity and consistency

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
source/bulkdata/profilexconf.c	Updated three `clock_gettime` calls to use `CLOCK_MONOTONIC` for measuring start time, processing time, and elapsed time; improved log messages for execution count and processing time
source/bulkdata/profile.c	Updated two `clock_gettime` calls to use `CLOCK_MONOTONIC` for measuring start and end times of report collection and generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dharshini555 · 2025-11-19T11:55:58Z

Code changes looks good to me.

rdkcmf-jenkins · 2025-11-19T11:56:14Z

Coverity Issue - Data race condition

Accessing "profile->grepSeekProfile->execCounter" without holding lock "plMutex". Elsewhere, "_GrepSeekProfile.execCounter" is written to with "plMutex" held 2 out of 2 times.

Medium Impact, CWE-366
MISSING_LOCK

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
source/bulkdata/profile.c:344

source/bulkdata/profile.c

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profile.c

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

source/bulkdata/profilexconf.c

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profilexconf.c

@@ -451,7 +451,7 @@ static void* CollectAndReportXconf(void* data)
            T2Warning("Failed to save grep config to file for profile: %s\n", profile->name);
        }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

rdkcmf-jenkins · 2025-11-19T11:56:14Z

source/bulkdata/profilexconf.c

Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Unchecked return value

Calling "clock_gettime" without checking return value (as is done elsewhere 1 out of 1 times).

Medium Impact, CWE-252
CHECKED_RETURN

source/bulkdata/profile.c

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-24T12:47:32Z

source/bulkdata/profilexconf.c

+            clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+            if(clockReturn)
+            {
+                T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profilexconf.c

Copilot · 2025-11-24T12:47:32Z

source/bulkdata/profilexconf.c

+        clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+        if (clockReturn)
+        {
+            T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profile.c

Copilot · 2025-11-24T12:47:33Z

source/bulkdata/profile.c

+        clockReturn |= clock_gettime(CLOCK_MONOTONIC, &endTime);
+        if(clockReturn)
+        {
+            T2Warning("Error in Fetching the time Elapsed");


The error message "Error in Fetching the time Elapsed" is grammatically incorrect and unclear. Consider revising to "Error fetching elapsed time" or "Failed to get time from clock_gettime()" to be more concise and accurate.

Suggested change

T2Warning("Error in Fetching the time Elapsed");

T2Warning("Failed to get time from clock_gettime()");

source/bulkdata/profilexconf.c

…ONIC Reason for Change: Changing CLOCK_REALTIME to CLOCK_MONOTONIC to avoid clock drifts impact in the calculations Test Procedure: When Telemetry report generation is in progress change the time. The processing time should have a valid value Risks: Low Priority: P1

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/bulkdata/profilexconf.c

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/bulkdata/profile.c

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

source/bulkdata/profile.c

Copilot · 2026-03-05T10:54:31Z

source/bulkdata/profile.c

+        if(clockReturn)
+        {
+            T2Warning("Failed to get time from clock_gettime()");
+        }


The new warning log for clock_gettime() failures doesn’t include errno details, which makes diagnosing failures difficult. Since clock_gettime() sets errno, consider logging strerror(errno) (and ideally whether startTime or endTime capture failed).

source/bulkdata/profilexconf.c

Copilot AI review requested due to automatic review settings November 19, 2025 11:46

shivabhaskar requested a review from a team as a code owner November 19, 2025 11:46

Copilot started reviewing on behalf of shivabhaskar November 19, 2025 11:48 View session

Copilot finished reviewing on behalf of shivabhaskar November 19, 2025 11:49

Copilot AI reviewed Nov 19, 2025

View reviewed changes

rdkcmf-jenkins reviewed Nov 19, 2025

View reviewed changes

rdkcmf-jenkins reviewed Nov 24, 2025

View reviewed changes

source/bulkdata/profile.c Show resolved Hide resolved

source/bulkdata/profile.c Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 24, 2025 12:44

Copilot started reviewing on behalf of shivabhaskar November 24, 2025 12:44 View session

Copilot finished reviewing on behalf of shivabhaskar November 24, 2025 12:46

Copilot AI reviewed Nov 24, 2025

View reviewed changes

shibu-kv previously approved these changes Nov 26, 2025

View reviewed changes

shivabhaskar added 3 commits December 17, 2025 13:25

Coverity Fix

ec64c37

Fix Formatting and Coverity

d048d01

Copilot AI review requested due to automatic review settings December 17, 2025 21:25

shibu-kv force-pushed the topic/RDKEMW-10467 branch from 9a7e5ba to d048d01 Compare December 17, 2025 21:25

Copilot started reviewing on behalf of shibu-kv December 17, 2025 21:25 View session

Copilot AI reviewed Dec 17, 2025

View reviewed changes

source/bulkdata/profilexconf.c Show resolved Hide resolved

shibu-kv and others added 2 commits January 22, 2026 08:13

Merge branch 'develop' into topic/RDKEMW-10467

7d5d223

Merge branch 'develop' into topic/RDKEMW-10467

e5b5017

Copilot AI review requested due to automatic review settings February 19, 2026 07:49

Copilot started reviewing on behalf of dharshini555 February 19, 2026 07:50 View session

Copilot AI reviewed Feb 19, 2026

View reviewed changes

source/bulkdata/profile.c Outdated Show resolved Hide resolved

dharshini555 added 2 commits March 4, 2026 17:23

Merge branch 'develop' into topic/RDKEMW-10467

f2507df

Fix formatting and coverity

9f37ece

Copilot AI review requested due to automatic review settings March 5, 2026 10:49

dharshini555 dismissed shibu-kv’s stale review via 9f37ece March 5, 2026 10:49

Copilot started reviewing on behalf of dharshini555 March 5, 2026 10:50 View session

Copilot AI reviewed Mar 5, 2026

View reviewed changes

shibu-kv approved these changes Mar 6, 2026

View reviewed changes

shibu-kv closed this Mar 6, 2026

shibu-kv reopened this Mar 6, 2026

github-actions bot locked and limited conversation to collaborators Mar 6, 2026

		@@ -451,7 +451,7 @@ static void* CollectAndReportXconf(void* data)
		T2Warning("Failed to save grep config to file for profile: %s\n", profile->name);
		}

	T2Warning("Error in Fetching the time Elapsed");
	T2Warning("Failed to get time from clock_gettime()");

Conversation

shivabhaskar commented Nov 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dharshini555 commented Nov 19, 2025

Uh oh!

rdkcmf-jenkins commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverity Issue - Data race condition

Issue location

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

rdkcmf-jenkins Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Unchecked return value

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rdkcmf-jenkins commented Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading

rdkcmf-jenkins Nov 19, 2025 •

edited

Loading