Allow to choose an explicit prefix for rdkit.#45
Open
booti386 wants to merge 1 commit intordkit-rs:mainfrom
Open
Allow to choose an explicit prefix for rdkit.#45booti386 wants to merge 1 commit intordkit-rs:mainfrom
booti386 wants to merge 1 commit intordkit-rs:mainfrom
Conversation
xrl
pushed a commit
that referenced
this pull request
Mar 13, 2026
- Add null pointer check in RWMol::from_smarts() to prevent segfault on invalid SMARTS input (addresses #18, supersedes #19). Introduces RWMolError type mirroring the existing ROMolError pattern. - Support RDKIT_PREFIX env var to allow specifying a custom RDKit install prefix, overriding all other detection logic (supersedes #45). Includes cargo:rerun-if-env-changed and empty string handling. https://claude.ai/code/session_01QNQtwSN1RrM5XCnXZoA6pb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.