Skip to content

feat(webui): add model, from-step, steps, exclude, dry-run to start pipeline dialogs #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nextlevelshit merged 2 commits into from
Apr 3, 2026
Merged

feat(webui): add model, from-step, steps, exclude, dry-run to start pipeline dialogs #698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2d1475
docs: add spec, plan, and tasks for #690 webui start dialog flags
nextlevelshit Mar 30, 2026
ef988a6
feat(webui): add model, from-step, steps, exclude, dry-run to start p…
nextlevelshit Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
169 changes: 169 additions & 0 deletions internal/webui/handlers_control_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,175 @@ func TestHandleForkPoints_WithCheckpoints(t *testing.T) {
}
}

// --- Start Pipeline with advanced options tests ---

func TestHandleStartPipeline_WithModel(t *testing.T) {
srv, _ := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2"})

body := strings.NewReader(`{"input":"test","model":"haiku"}`)
req := httptest.NewRequest("POST", "/api/pipelines/test-pipeline/start", body)
req.SetPathValue("name", "test-pipeline")
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleStartPipeline(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", rec.Code, rec.Body.String())
}

var resp StartPipelineResponse
if err := json.NewDecoder(rec.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.PipelineName != "test-pipeline" {
t.Errorf("expected pipeline name 'test-pipeline', got %q", resp.PipelineName)
}
if resp.Status != "running" {
t.Errorf("expected status 'running', got %q", resp.Status)
}
}

func TestHandleStartPipeline_WithSteps(t *testing.T) {
srv, _ := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2", "step3"})

body := strings.NewReader(`{"input":"test","steps":"step1,step3"}`)
req := httptest.NewRequest("POST", "/api/pipelines/test-pipeline/start", body)
req.SetPathValue("name", "test-pipeline")
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleStartPipeline(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", rec.Code, rec.Body.String())
}
}

func TestHandleStartPipeline_WithExclude(t *testing.T) {
srv, _ := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2", "step3"})

body := strings.NewReader(`{"input":"test","exclude":"step2"}`)
req := httptest.NewRequest("POST", "/api/pipelines/test-pipeline/start", body)
req.SetPathValue("name", "test-pipeline")
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleStartPipeline(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", rec.Code, rec.Body.String())
}
}

func TestHandleStartPipeline_DryRun(t *testing.T) {
srv, _ := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2"})

body := strings.NewReader(`{"input":"test","dry_run":true}`)
req := httptest.NewRequest("POST", "/api/pipelines/test-pipeline/start", body)
req.SetPathValue("name", "test-pipeline")
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleStartPipeline(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201 for dry-run, got %d: %s", rec.Code, rec.Body.String())
}

var resp StartPipelineResponse
if err := json.NewDecoder(rec.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.PipelineName != "test-pipeline" {
t.Errorf("expected pipeline name 'test-pipeline', got %q", resp.PipelineName)
}
}

func TestHandleStartPipeline_DryRunCreatesCompletedRun(t *testing.T) {
srv, rwStore := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2"})

body := strings.NewReader(`{"input":"test","dry_run":true}`)
req := httptest.NewRequest("POST", "/api/pipelines/test-pipeline/start", body)
req.SetPathValue("name", "test-pipeline")
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleStartPipeline(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201 for dry-run, got %d: %s", rec.Code, rec.Body.String())
}

// Dry-run creates a run
runs, err := rwStore.ListRuns(state.ListRunsOptions{Limit: 10})
if err != nil {
t.Fatalf("failed to list runs: %v", err)
}
if len(runs) != 1 {
t.Fatalf("expected 1 run after dry-run, got %d", len(runs))
}
}

// --- SubmitRun with advanced options tests ---

func TestHandleSubmitRun_WithModel(t *testing.T) {
srv, _ := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2"})

body := strings.NewReader(`{"pipeline":"test-pipeline","input":"test","model":"opus"}`)
req := httptest.NewRequest("POST", "/api/runs", body)
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleSubmitRun(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201, got %d: %s", rec.Code, rec.Body.String())
}

var resp SubmitRunResponse
if err := json.NewDecoder(rec.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.PipelineName != "test-pipeline" {
t.Errorf("expected pipeline 'test-pipeline', got %q", resp.PipelineName)
}
}

func TestHandleSubmitRun_DryRun(t *testing.T) {
srv, rwStore := testServer(t)
setupPipelineDir(t, "test-pipeline", []string{"step1", "step2"})

body := strings.NewReader(`{"pipeline":"test-pipeline","input":"test","dry_run":true}`)
req := httptest.NewRequest("POST", "/api/runs", body)
req.Header.Set("Content-Type", "application/json")
rec := httptest.NewRecorder()
srv.handleSubmitRun(rec, req)

if rec.Code != http.StatusCreated {
t.Fatalf("expected 201 for dry-run, got %d: %s", rec.Code, rec.Body.String())
}

var resp SubmitRunResponse
if err := json.NewDecoder(rec.Body).Decode(&resp); err != nil {
t.Fatalf("failed to decode response: %v", err)
}
if resp.PipelineName != "test-pipeline" {
t.Errorf("expected pipeline name 'test-pipeline', got %q", resp.PipelineName)
}

// Dry-run creates a run
runs, err := rwStore.ListRuns(state.ListRunsOptions{Limit: 10})
if err != nil {
t.Fatalf("failed to list runs: %v", err)
}
if len(runs) != 1 {
t.Fatalf("expected 1 run after dry-run, got %d", len(runs))
}
}

// --- buildExecOptions / buildStepFilter tests ---

func TestIsHeartbeat(t *testing.T) {
tests := []struct {
name string
Expand Down
98 changes: 97 additions & 1 deletion internal/webui/templates/pipeline_detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,42 @@ <h3 id="quickstart-title">Start Pipeline: <span id="quickstart-name"></span></h3
<label for="quickstart-input">Input (optional)</label>
<textarea id="quickstart-input" rows="3" placeholder="Issue URL, feature description..."></textarea>
</div>
<details class="advanced-options">
<summary>Advanced Options</summary>
<div class="form-group">
<label for="qs-model">Model Override</label>
<select id="qs-model">
<option value="">Default (auto)</option>
<option value="haiku">Haiku</option>
<option value="sonnet">Sonnet</option>
<option value="opus">Opus</option>
</select>
</div>
<div class="form-group">
<label for="qs-from-step">Resume From Step</label>
<select id="qs-from-step" onchange="onQsFromStepChange()">
<option value="">Start from beginning</option>
</select>
</div>
<div class="form-group" id="qs-steps-group">
<label>Run Only These Steps</label>
<div id="qs-steps-checks" class="checkbox-list">
<span class="text-muted">Loading...</span>
</div>
</div>
<div class="form-group" id="qs-exclude-group">
<label>Exclude Steps</label>
<div id="qs-exclude-checks" class="checkbox-list">
<span class="text-muted">Loading...</span>
</div>
</div>
<div class="form-group">
<label class="checkbox-label">
<input type="checkbox" id="qs-dry-run">
Dry Run (validate without executing)
</label>
</div>
</details>
<div class="dialog-actions">
<button class="btn" onclick="hideQuickStart()">Cancel</button>
<button class="btn btn-primary" id="quickstart-submit" onclick="submitQuickStart()">Start</button>
Expand All @@ -127,6 +163,15 @@ <h3 id="quickstart-title">Start Pipeline: <span id="quickstart-name"></span></h3
quickStartPipeline = name;
document.getElementById('quickstart-name').textContent = name;
document.getElementById('quickstart-input').value = '';
// Reset advanced options
var modelEl = document.getElementById('qs-model');
if (modelEl) modelEl.value = '';
var fromStepEl = document.getElementById('qs-from-step');
if (fromStepEl) fromStepEl.innerHTML = '<option value="">Start from beginning</option>';
var dryRunEl = document.getElementById('qs-dry-run');
if (dryRunEl) dryRunEl.checked = false;
// Load step list
loadQsStepList(name);
document.getElementById('quickstart-dialog').showModal();
document.getElementById('quickstart-input').focus();
}
Expand All @@ -140,19 +185,70 @@ <h3 id="quickstart-title">Start Pipeline: <span id="quickstart-name"></span></h3
if (!quickStartPipeline) return;
var input = document.getElementById('quickstart-input').value;
var btn = document.getElementById('quickstart-submit');
var body = {input: input || ''};
// Collect advanced options
var opts = collectAdvancedOptions('qs');
Object.keys(opts).forEach(function(k) { body[k] = opts[k]; });

setButtonLoading(btn, true);
fetchJSON('/api/pipelines/' + encodeURIComponent(quickStartPipeline) + '/start', {
method: 'POST',
headers: {'Content-Type': 'application/json'},
body: JSON.stringify({input: input || ''})
body: JSON.stringify(body)
}).then(function(data) {
if (body.dry_run && data.findings !== undefined) {
showDryRunReport(data);
setButtonLoading(btn, false);
return;
}
showToast('Pipeline started: ' + data.run_id, 'success', 3000);
setTimeout(function() { window.location.href = '/runs/' + data.run_id; }, 500);
}).catch(function() {
setButtonLoading(btn, false);
});
}

function loadQsStepList(pipelineName) {
var fromStep = document.getElementById('qs-from-step');
var stepsChecks = document.getElementById('qs-steps-checks');
var excludeChecks = document.getElementById('qs-exclude-checks');
fetchJSON('/api/pipelines/' + encodeURIComponent(pipelineName)).then(function(data) {
var steps = data.steps || [];
var opts = '<option value="">Start from beginning</option>';
for (var i = 0; i < steps.length; i++) {
opts += '<option value="' + escapeHTML(steps[i].id) + '">' + escapeHTML(steps[i].id) + '</option>';
}
if (fromStep) fromStep.innerHTML = opts;
var checksHTML = '';
for (var i = 0; i < steps.length; i++) {
checksHTML += '<label class="checkbox-label"><input type="checkbox" name="qs-steps" value="' + escapeHTML(steps[i].id) + '"> ' + escapeHTML(steps[i].id) + '</label>';
}
if (stepsChecks) stepsChecks.innerHTML = checksHTML || '<span class="text-muted">No steps</span>';
var exclHTML = '';
for (var i = 0; i < steps.length; i++) {
exclHTML += '<label class="checkbox-label"><input type="checkbox" name="qs-exclude" value="' + escapeHTML(steps[i].id) + '"> ' + escapeHTML(steps[i].id) + '</label>';
}
if (excludeChecks) excludeChecks.innerHTML = exclHTML || '<span class="text-muted">No steps</span>';
}).catch(function() {
if (stepsChecks) stepsChecks.innerHTML = '<span class="text-muted">Failed to load steps</span>';
if (excludeChecks) excludeChecks.innerHTML = '<span class="text-muted">Failed to load steps</span>';
});
}

function onQsFromStepChange() {
var fromStep = document.getElementById('qs-from-step');
var stepsGroup = document.getElementById('qs-steps-group');
if (fromStep && fromStep.value) {
if (stepsGroup) stepsGroup.style.opacity = '0.5';
var checks = document.querySelectorAll('#qs-steps-checks input[type="checkbox"]');
for (var i = 0; i < checks.length; i++) { checks[i].checked = false; checks[i].disabled = true; }
} else {
if (stepsGroup) stepsGroup.style.opacity = '1';
var checks = document.querySelectorAll('#qs-steps-checks input[type="checkbox"]');
for (var i = 0; i < checks.length; i++) { checks[i].disabled = false; }
}
}

document.addEventListener('keydown', function(e) {
if (e.key === 'Escape') hideQuickStart();
});
Expand Down
Loading
Loading