Conversation
Upgrade to react 19
voliva
left a comment
There was a problem hiding this comment.
Thanks @rveciana for the contribution!
I see you have updated the devDependencies of the monorepo, but the @react-rxjs/core pacakge is left untouched, aside from linting/prettier changes.
I think we have to update the peerDependency of @react-rxjs/core to declare it's compatible with react@19
…sync-external-store
Change waitFor timeout and remove uneeded waitFor usage. Upgrade use-…
sync cpackage-lock.json
There was a problem hiding this comment.
Thanks again @rveciana!
It looks good to me, but you have removed some generics on the test files that gives me TS errors on my IDE - I tried adding a commit fixing those to this PR but I couldn't, you can cherry-pick it if you want: 6923301
The CI is failing for an unrelated issue with some code coverage tool we have, I'll take a look as a separate issue.
Add removed types again
|
Thanks for finding this. A wrong vscode configuration did it. |
|
@all-contributors please add @rveciana for maintenance |
|
I've put up a pull request to add @rveciana! 🎉 |
|
Published as @react-rxjs/core@0.10.8 |
Upgrade the dependencies for the project
Fix broken tests because of the vitest upgrade
Fix small errors because of the react upgrade