Skip to content

fix(ios): skip imageColor tint when New-Arch defaults it to 0 #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smsfnxbtww-rgb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): skip imageColor tint when New-Arch defaults it to 0 #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ios/Shared/RCTMenuItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,14 @@ class RCTMenuAction {
if self.image === nil {
self.image = UIImage(named: image as String)
}
if let imageColor = details["imageColor"] {
// Under React Native's New Architecture, the codegen-generated
// MenuViewActionsSubactionsStruct declares `int imageColor{0}` as
// the default, so the bridge always forwards a value even when JS
// didn't pass one. Without this guard the unwrap below would
// succeed with `imageColor == 0`, and `RCTConvert.uiColor(0)`
// returns a fully transparent UIColor — every SF Symbol passed
// via `image` would render invisible. Closes #1198, refs #1034 #1002.
if let imageColor = details["imageColor"], (imageColor as? Int) != 0 {
self.image = self.image?.withTintColor(RCTConvert.uiColor(imageColor), renderingMode: .alwaysOriginal)
}
}
Expand Down