Skip to content

fix(metro-resolver): support multiple wildcards or strict single wildcard in subpath patterns robustly #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatrixNeoKozak wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(metro-resolver): support multiple wildcards or strict single wildcard in subpath patterns robustly #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/metro-resolver/src/utils/isSubpathDefinedInExportsLike.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ export function isSubpathDefinedInExportsLike(
// Attempt to match after expanding any subpath pattern keys
for (const key of exportsLikeMap.keys()) {
if (
key.split('*').length === 2 &&
matchSubpathPattern(key, subpath) != null
) {
return true;
Expand Down
7 changes: 6 additions & 1 deletion packages/metro-resolver/src/utils/matchSubpathPattern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ export function matchSubpathPattern(
subpathPattern: string,
subpath: string,
): string | null {
const [patternBase, patternTrailer] = subpathPattern.split('*');
const wildcardIndex = subpathPattern.indexOf('*');
if (wildcardIndex === -1 || subpathPattern.indexOf('*', wildcardIndex + 1) !== -1) {
return null;
}
const patternBase = subpathPattern.substring(0, wildcardIndex);
const patternTrailer = subpathPattern.substring(wildcardIndex + 1);

if (
subpath.startsWith(patternBase) &&
Expand Down
Loading