Resolver: Don't resolve directories as assets

[robhogan]

A package or directory whose name ends in one of resolver.assetExts can't be imported, because the resolver treats it as an asset file. require('lodash.zip') (a real package) fails with:

Failed to get the SHA-1 for: /path/to/project/node_modules/lodash.zip.

Any asset extension causes this, and it also breaks relative imports of directories ending in an extension, eg require('./icons.png') where icons.png is a directory containing an index.js.

This change only accepts asset candidates that are files (type === 'f'), so directories fall through to package resolution as they would for any other name.

Fixes: #441

Changelog:

 - **[Fix]**: Resolver: packages and directories named with an asset extension (e.g. `lodash.zip`) resolve as modules rather than failing as assets

Test plan:
New tests in resolver-test.js for a package (lodash.zip) and a relative directory (icons.png), both failing before this change (resolving to the directory itself) and passing after.

Also checked end-to-end by patching published metro@0.87.1: require('lodash.zip') builds, and a real ./assets/pic.png still resolves as an asset.

[Copilot]

🟢 Approval recommended

The fix is narrowly scoped, correct, and covered by relevant regression tests.

0 open findings

What changed in this PR

Prevents directories with asset-like extensions from being incorrectly resolved as assets.

Changes:

• Restricts asset candidates to files.
• Adds package and relative-directory regression tests.

File	Description
createModuleResolver.js	Filters non-file asset candidates.
resolver-test.js	Tests asset-extension directory resolution.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[meta-codesync]

@Abbondanzo has imported this pull request. If you are a Meta employee, you can view this in D124673317.