[RN] Make yarn the source of truth for JS lint/format - #57784
Draft
mattcarrollcode wants to merge 1 commit into
Draft
[RN] Make yarn the source of truth for JS lint/format#57784mattcarrollcode wants to merge 1 commit into
mattcarrollcode wants to merge 1 commit into
Conversation
## Summary Point synced JavaScript formatting and linting at the repository's own Prettier + ESLint so CI is the source of truth: add `yarn f` (Prettier), expand the Prettier globs to all JS-family extensions, and make the CI ESLint step propagate its exit status instead of swallowing it. ## Changelog [Internal] ## Test Plan `yarn lint`, `yarn format-check`, and `yarn f` run from the repo root; the GitHub `lint` job runs both on this PR. Changelog: [Internal]
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point synced JavaScript formatting and linting at the repository's own Prettier +
ESLint so CI is the source of truth: add
yarn f(Prettier), expand the Prettierglobs to all JS-family extensions, and make the CI ESLint step propagate its exit
status instead of swallowing it.
Changelog
[Internal]
Test Plan
yarn lint,yarn format-check, andyarn frun from the repo root; the GitHublintjob runs both on this PR.Changelog: [Internal]