Skip to content

Fix Image.getSize for Android data URIs - #57788

Open
RealBhupesh wants to merge 1 commit into
react:mainfrom
RealBhupesh:agent/57787-image-getsize-data-uri
Open

Fix Image.getSize for Android data URIs#57788
RealBhupesh wants to merge 1 commit into
react:mainfrom
RealBhupesh:agent/57787-image-getsize-data-uri

Conversation

@RealBhupesh

@RealBhupesh RealBhupesh commented Aug 2, 2026

Copy link
Copy Markdown

Summary

  • Route Android data: URIs through Fresco's decoded-image pipeline for Image.getSize() and Image.getSizeWithHeaders().
  • Keep the encoded-image metadata path for other URI schemes so network and file images retain their true source dimensions.
  • Add regression coverage for both public methods.

Changelog:

[ANDROID] [FIXED] - Image.getSize now supports data URIs on Android.

Fixes #57787

Test plan

  • Added unit coverage for both data: URI entry points.
  • Android unit tests could not run locally because this environment has no configured Android SDK (ANDROID_HOME/ANDROID_SDK_ROOT).

@meta-cla

meta-cla Bot commented Aug 2, 2026

Copy link
Copy Markdown

Hi @RealBhupesh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@RealBhupesh
RealBhupesh marked this pull request as ready for review August 2, 2026 07:39
@meta-cla

meta-cla Bot commented Aug 2, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 2, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

【Android】【0.86.2】Image.getSize() fails for data: URIs on Android since v0.86

1 participant