Skip to content

Treat NaN border widths as unset - #57789

Open
RealBhupesh wants to merge 1 commit into
react:mainfrom
RealBhupesh:agent/57780-border-width-nan
Open

Treat NaN border widths as unset#57789
RealBhupesh wants to merge 1 commit into
react:mainfrom
RealBhupesh:agent/57780-border-width-nan

Conversation

@RealBhupesh

@RealBhupesh RealBhupesh commented Aug 2, 2026

Copy link
Copy Markdown

Summary

  • Normalize Float.NaN border widths to unset values in the shared logical border-inset resolver.
  • Add a regression test confirming NaN edges fall back to the applicable all-edge width.

Changelog:

[ANDROID] [FIXED] - Resetting border widths no longer clips children in rounded overflow-hidden views.

Fixes #57780

Test plan

  • Added BorderInsetsTest.nanBorderWidthsAreTreatedAsUnset.
  • Android unit tests could not run locally because this environment has no configured Android SDK (ANDROID_HOME/ANDROID_SDK_ROOT).

@meta-cla

meta-cla Bot commented Aug 2, 2026

Copy link
Copy Markdown

Hi @RealBhupesh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@RealBhupesh
RealBhupesh marked this pull request as ready for review August 2, 2026 07:39
@meta-cla

meta-cla Bot commented Aug 2, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 2, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Aug 2, 2026
@meta-codesync

meta-codesync Bot commented Aug 2, 2026

Copy link
Copy Markdown

@fabriziocucci has imported this pull request. If you are a Meta employee, you can view this in D114520650.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] Removing borderWidth from a rounded overflow:hidden View stops all its children from being drawn (NaN reaches the padding-box clip)

1 participant