feat: Add clip-path support for iOS - #58543
Open
marcinszalski-callstack wants to merge 5 commits into
Open
marcinszalski-callstack wants to merge 5 commits into
marcinszalski-callstack wants to merge 5 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
Author
|
continuation of the previous PR by Kamil: 54700 |
facebook-github-tools
Bot
added
the
Shared with Meta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds support for
clip-pathCSS attribute for JS. It follows CSS spec described here. It does not provide support for SVG source (<clip-source>values), what can be added in the additional PR if needed. Supported syntax is[<basic-shape>] || <geometry-box>]with almost full support of every basic shape (<basic-shape> = circle | ellipse | rect | polygon | inset | xywh) and references boxes (<geometry-box> = margin-box | border-box | padding-box | content-box | fill-box | stoke-box | view-box).Work has been split into three PRs for more convenient reviewing process. This part adds iOS support for clipping, path and bounds calculations, native CSS parser.
Changelog:
[IOS] [ADDED] - Add clip-path support for iOS
Test Plan:
Merge JS and Android PRs and run RNTester app.
ClipPathExample.js)CSSClipPathTest.cpp)