Skip to content

fix: paint Android text decorations when a text update keeps the view's frame #58579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatiPl01 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

fix: paint Android text decorations when a text update keeps the view's frame #58579

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .../react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,15 @@ protected void onDraw(Canvas canvas) {

if (spanned != null) {
Layout layout = getLayout();
if (layout == null && getWidth() > 0 && getHeight() > 0) {
// setText drops the Layout and Fabric re-measures only on a frame change, so a text
// update that kept the frame reaches onDraw without one and the effects below would be
// skipped. Rebuild it here; TextView.onDraw would build one for the text anyway.
measure(
MeasureSpec.makeMeasureSpec(getWidth(), MeasureSpec.EXACTLY),
MeasureSpec.makeMeasureSpec(getHeight(), MeasureSpec.EXACTLY));
layout = getLayout();
}
if (layout != null) {
CanvasEffectSpan[] drawSpans =
spanned.getSpans(0, spanned.length(), CanvasEffectSpan.class);
Expand Down
Loading